Closed Bug 695513 Opened 8 years ago Closed 8 years ago

Remote reftests should fail more cleanly if an invalid test manifest is passed in

Categories

(Testing :: Reftest, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: wlach, Assigned: jmaher)

Details

Attachments

(2 files)

Right now we go ahead and try to get the manifest anyway, which causes confusing errors. It's easy to tell if the user passed a valid filename on startup (in fact the code to check is already there), so let's do that.
There's not really a lot to say about this patch: it pretty much just does what it says. :) I moved the checking of the command line arguments above the starting of the webserver as we get a zombie process if we exit after it has started. IMO it makes more sense there anyway.
Assignee: nobody → wlachance
Attachment #567884 - Flags: review?(jmaher)
Comment on attachment 567884 [details] [diff] [review]
Remote reftests should fail cleanly if invalid test manifest specified

Review of attachment 567884 [details] [diff] [review]:
-----------------------------------------------------------------

great!
Attachment #567884 - Flags: review?(jmaher) → review+
Assignee: wlachance → jmaher
Status: NEW → ASSIGNED
Attachment #568005 - Flags: review?(martijn.martijn)
Attachment #568005 - Flags: review?(martijn.martijn) → review+
https://hg.mozilla.org/mozilla-central/rev/34bfd522f630

leaving open since looks not complete
Target Milestone: --- → mozilla10
ah here is the remaining part
https://hg.mozilla.org/mozilla-central/rev/e1c79e98e4ee
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.