Closed Bug 695595 Opened 8 years ago Closed 8 years ago

Bookmarks don't open URL correctly

Categories

(Firefox for Android :: General, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: kats)

Details

Attachments

(1 file)

If I open the Bookmarks list and tap a bookmark, the browser does not load the bookmarked URL. The screen flashes, but nothing happens. The current page is still the visible web content.
Moving patch from bug 695100 over to this one.
Assignee: nobody → kgupta
Status: NEW → ASSIGNED
Attachment #568022 - Flags: review?(mark.finkle)
Attachment #568022 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/projects/birch/rev/9f0b55203981
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Though this patch works, its better to have the application stack minimal.
In current case, the application stack will have GeckoApp -> GeckoBookmarks -> GeckoApp.
Instead, if GeckoBookmarks can be started as "startActivityForResult" and the return value be used to open a new tab, the application stack will remain at GeckoApp, once it returns from GeckoBookmarks.
AwesomeBar, ShowTabs work in this fashion.
(In reply to Sriram Ramasubramanian [:sriram] from comment #3)

That sounds pretty reasonable, I'll see if that works when I fix bug 695199
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111021 Firefox/10.0a1 Fennec/10.0a1 (birch)
Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.