695667 - search suggestions error

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

This url kicks up a server error:

http://support.mozilla.com/en-US/search/suggestions?q=www.google.com%2Fig

The error email that comes back has a traceback implicating oedipus and sphinx.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Traceback (most recent call last):

  File "/data/www/support.mozilla.com/kitsune/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/support.mozilla.com/kitsune/vendor/src/django/django/utils/decorators.py", line 93, in _wrapped_view
    response = view_func(request, *args, **kwargs)

  File "/data/www/support.mozilla.com/kitsune/apps/search/views.py", line 403, in suggestions
    question_search.filter(has_helpful=True).query(term)[:5]))

  File "/data/www/support.mozilla.com/kitsune/vendor/src/oedipus/oedipus/__init__.py", line 325, in __iter__
    return iter(self._results())

  File "/data/www/support.mozilla.com/kitsune/vendor/src/oedipus/oedipus/__init__.py", line 504, in _results
    raw = self._raw()  # side effect: sets _results_class and _fields

  File "/data/www/support.mozilla.com/kitsune/vendor/src/oedipus/oedipus/__init__.py", line 535, in _raw
    raise SearchError('Sphinx had an error while performing a '

SearchError: Sphinx had an error while performing a query.


It happened a few times last night.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

It's a problem with switching the suggestions view to oedipus in 7bae564.

Grabifying this to look into it more.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

The problem was that oedipus treated Sphinx errors differently than the old kitsune search client code did.  I tweaked oedipus to log an error, but return an empty result set.

I also fixed the specific problem here where / wasn't getting escaped and thus kicked up a Sphinx syntax error.

Fixed in master in https://github.com/jsocol/kitsune/commit/6b88601e20ceca2b5a80274937653306403a7f20

Fixed in next in https://github.com/jsocol/kitsune/commit/2008617cf5c7c6fc4801ad05fe9cb67f7e9adcb1

To test, hit the example url in the description and make sure it returns a json file rather than a "oh noes!  an error has occurred!" page.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Putting this in the 2011-10-25 target, but it went out on 2011-10-19.

Comment 5

[Rebecca Billings [:rbillings]]

Verified hitting the url asks user if they want to save the file, no error message is display, no error email is sent.