Last Comment Bug 695728 - Handle tabDetached events in the script debugger
: Handle tabDetached events in the script debugger
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: Trunk
: All All
-- normal (vote)
: ---
Assigned To: Panos Astithas [:past]
: J. Ryan Stinnett [:jryans] (use ni?)
Depends on:
Blocks: minotaur
  Show dependency treegraph
Reported: 2011-10-19 09:50 PDT by Panos Astithas [:past]
Modified: 2011-10-19 23:11 PDT (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Working patch (3.15 KB, patch)
2011-10-19 09:59 PDT, Panos Astithas [:past]
dcamp: review+
Details | Diff | Splinter Review

Description User image Panos Astithas [:past] 2011-10-19 09:50:24 PDT
The debugger UI currently does not handle tabDetached events at all, relying on unload events instead. This is not a practical problem at the moment, but debugging a remote instance with no access to its unload events wouldn't work.
Comment 1 User image Panos Astithas [:past] 2011-10-19 09:59:14 PDT
Created attachment 568100 [details] [diff] [review]
Working patch

The tabDetached handler may have to do different work when we support debugging remote instances, but this should suffice for now.

Another change is that BrowserTabActor.onDetach now returns "detached" instead of "tabDetached", since we need to differentiate between the unsolicited event and the response to a client-initiated request, but also for consistency with the thread actor response.

Note You need to log in before you can comment on or make changes to this bug.