Closed
Bug 695728
Opened 13 years ago
Closed 13 years ago
Handle tabDetached events in the script debugger
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: past, Assigned: past)
References
Details
Attachments
(1 file)
|
3.15 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
The debugger UI currently does not handle tabDetached events at all, relying on unload events instead. This is not a practical problem at the moment, but debugging a remote instance with no access to its unload events wouldn't work.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•13 years ago
|
||
The tabDetached handler may have to do different work when we support debugging remote instances, but this should suffice for now. Another change is that BrowserTabActor.onDetach now returns "detached" instead of "tabDetached", since we need to differentiate between the unsolicited event and the response to a client-initiated request, but also for consistency with the thread actor response.
Attachment #568100 -
Flags: review?(dcamp)
|
||
Updated•13 years ago
|
Attachment #568100 -
Flags: review?(dcamp) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/570b03e53e37
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•