The default bug view has changed. See this FAQ.

Handle tabDetached events in the script debugger

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The debugger UI currently does not handle tabDetached events at all, relying on unload events instead. This is not a practical problem at the moment, but debugging a remote instance with no access to its unload events wouldn't work.
Assignee: nobody → past
Status: NEW → ASSIGNED
Created attachment 568100 [details] [diff] [review]
Working patch

The tabDetached handler may have to do different work when we support debugging remote instances, but this should suffice for now.

Another change is that BrowserTabActor.onDetach now returns "detached" instead of "tabDetached", since we need to differentiate between the unsolicited event and the response to a client-initiated request, but also for consistency with the thread actor response.
Attachment #568100 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #568100 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/570b03e53e37
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.