695780 - Affiliates: banner color text is non localized

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Chris More [:cmore]]

Regardless of what locale you are in, all of the color text in the selection box is en-US only. The database is en-US and should be translated into the locale of the user's profile selection instead of only en-US.

Correct strings are in the .pot file:

https://svn.mozilla.org/projects/l10n-misc/trunk/affiliates/locale/templates/LC_MESSAGES/messages.pot

There is also this note in the unused strings file here:

https://github.com/mozilla/affiliates/blob/master/apps/shared/templates/shared/unused_strings.html

So it looks like the strings were put in this file to be extracted, but the functionality of putting those back into the view/template was not completed or resolved.

Comment 1

[Osmose [:osmose, :mkelly]]

This should have been fixed in https://github.com/mozilla/affiliates/commit/231f70f9701c862e15a05ef46beb77801f0b8a60

Comment 2

[Chris More [:cmore]]

Attachment: Polish colors

Comment 3

[Chris More [:cmore]]

Niebieski = blue in Polish when my browser is set to locale = PL.