695791 - [SkipList] Add google_breakpad::ExceptionHandler::HandleInvalidParameter to signatureSentinels

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[(not currently active) Ted Mielczarek]

We should add the following to signatureSentinels:
google_breakpad::ExceptionHandler::HandleInvalidParameter(wchar_t const*,wchar_t const*,wchar_t const*,unsigned int,unsigned int)

Yeah, it's really long. Sorry.

We get these on the stack when we call certain Microsoft CRT methods with invalid parameters. Breakpad's "invalid parameter handler" gets called, which has this signature. bug 694344 shows the kind of stack we wind up with here, we need to get better signatures out of it.

Comment 1

[Robert Kaiser]

Laura, can we get this one into ideally the next Socorro release?

Comment 2

[Laura Thomson :laura]

In
https://github.com/mozilla/socorro/pull/107

Lars: r?

Comment 3

[K Lars Lohn [:lars] [:klohn]]

I think just adding this frame signature to the signatureSentinels will be insufficient to get you a better signature.  Remember, the signatureSentinel rule only tells Socorro what frame is to be considered as the top of the stack when applying the other skiplist rules.  

Adding your signature to signatureSentinels will result in "google_breakpad::ExceptionHandler..." being the signature for the crash.  I suspect you're likely going to need to add this same frame signature as prefixSignature or irrelevantSignature to get a better over all signature.

Comment 4

[(not currently active) Ted Mielczarek]

Ah. I must have misread the docs on that. We should also add it to irrelevantSignature.

Comment 5

[Laura Thomson :laura]

Updated pull request https://github.com/mozilla/socorro/pull/109

Comment 6

[Laura Thomson :laura]

Added spaces after commas in the signature to make it canonical.  (New commit in the PR).

https://github.com/lauraxt/socorro/commit/8818d14ee080910096328794c36fcd8547882062

Comment 7

[[github robot]]

Commits pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/952b652ded0bbef9b37f44533fba43ca18ed7086
Need to add this to the irrelevant signatures too as pointed out by
Lars. (bug 695791)

https://github.com/mozilla/socorro/commit/8818d14ee080910096328794c36fcd8547882062
Make the new sentinel signature canonical (bug 695791)