Closed Bug 695859 Opened 8 years ago Closed 8 years ago

Don't progressively display images during decode if we have all of the data

Categories

(Core :: ImageLib, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12
Tracking Status
firefox12 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

This fixes the problem shown in bug 626613. When we have all of the data, painting during decode just keeps us from finishing the decode sooner.
Attached patch Do itSplinter Review
Attachment #568224 - Flags: review?(bobbyholley+bmo)
Comment on attachment 568224 [details] [diff] [review]
Do it

This could turn out to be quite a significant behavioral change. It seems like a good idea in all the cases that come to mind, but I'm sure there are ones I haven't thought of.

Please test drive it a bit, and keep an eye on mozillazine after it lands to see what the masses have to say.

r=bholley
Attachment #568224 - Flags: review?(bobbyholley+bmo) → review+
Blocks: 698298
Assignee: nobody → jmuizelaar
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/df2cf9afad63
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Duplicate of this bug: 698298
If this is safe, can we look at landing this on Aurora too?
I don't think we should fast-track this.
Is there something QA can do to verify this fix?
Whiteboard: [qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #7)
> Is there something QA can do to verify this fix?

Not really, no.
Whiteboard: [qa?] → [qa-]
You need to log in before you can comment on or make changes to this bug.