Closed Bug 695861 Opened 8 years ago Closed 8 years ago

"ASSERTION: Can't find frame in lines!" with -moz-column, "unicode-bidi: -moz-isolate"

Categories

(Core :: Layout, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: jruderman, Assigned: smontagu)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files, 2 obsolete files)

###!!! ASSERTION: Can't find frame in lines!: 'hasNext', file layout/base/nsBidiPresUtils.cpp, line 377

###!!! ABORT: comparing iterators over different lists: 'mListLink == aOther.mListLink', file layout/generic/nsLineBox.h, line 722

This testcase uses a layout feature added recently, in bug 613149.
Attached file stack trace
Assignee: nobody → smontagu
Attached patch Patch (obsolete) — Splinter Review
Attachment #570953 - Flags: review?(roc)
Attached patch Patch (obsolete) — Splinter Review
The real patch this time
Attachment #570953 - Attachment is obsolete: true
Attachment #570953 - Flags: review?(roc)
Attachment #570955 - Flags: review?(roc)
Can you explain what the bug is and why this fixes it?
Attached patch Patch v.2Splinter Review
Putting a description of the bug into words made me realize that there is a simpler fix for it :)

What was happening was that when a bidi continuation in an element with unicode-bidi: -moz-isolate crossed a column break, we were passing the saved mPrevFrame from the previous column in the subparagraph into AdvanceLineIteratorToFrame, even though we had meanwhile created a new nsBlockInFlowLineIterator for the new column.

The new patch zeros out the mPrevFrame in the subparagraph as well as the containing paragraph when creating the new line iterator.
Attachment #570955 - Attachment is obsolete: true
Attachment #570955 - Flags: review?(roc)
Attachment #571496 - Flags: review?(roc)
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/3025c93444a6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.