Closed Bug 695861 Opened 8 years ago Closed 8 years ago
"ASSERTION: Can't find frame in lines!" with -moz-column, "unicode-bidi: -moz-isolate"
###!!! ASSERTION: Can't find frame in lines!: 'hasNext', file layout/base/nsBidiPresUtils.cpp, line 377 ###!!! ABORT: comparing iterators over different lists: 'mListLink == aOther.mListLink', file layout/generic/nsLineBox.h, line 722 This testcase uses a layout feature added recently, in bug 613149.
The real patch this time
Can you explain what the bug is and why this fixes it?
Putting a description of the bug into words made me realize that there is a simpler fix for it :) What was happening was that when a bidi continuation in an element with unicode-bidi: -moz-isolate crossed a column break, we were passing the saved mPrevFrame from the previous column in the subparagraph into AdvanceLineIteratorToFrame, even though we had meanwhile created a new nsBlockInFlowLineIterator for the new column. The new patch zeros out the mPrevFrame in the subparagraph as well as the containing paragraph when creating the new line iterator.
Attachment #571496 - Flags: review?(roc) → review+
Comment on attachment 571496 [details] [diff] [review] Patch v.2 https://hg.mozilla.org/integration/mozilla-inbound/rev/3025c93444a6
Attachment #571496 - Flags: checkin+
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla10
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.