The default bug view has changed. See this FAQ.

"ASSERTION: Can't find frame in lines!" with -moz-column, "unicode-bidi: -moz-isolate"

RESOLVED FIXED in mozilla10

Status

()

Core
Layout
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: smontagu)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla10
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Created attachment 568194 [details]
testcase (asserts fatally when loaded)

###!!! ASSERTION: Can't find frame in lines!: 'hasNext', file layout/base/nsBidiPresUtils.cpp, line 377

###!!! ABORT: comparing iterators over different lists: 'mListLink == aOther.mListLink', file layout/generic/nsLineBox.h, line 722

This testcase uses a layout feature added recently, in bug 613149.
(Reporter)

Comment 1

6 years ago
Created attachment 568195 [details]
stack trace
(Assignee)

Updated

6 years ago
Assignee: nobody → smontagu
(Assignee)

Comment 2

6 years ago
Created attachment 570953 [details] [diff] [review]
Patch
Attachment #570953 - Flags: review?(roc)
(Assignee)

Comment 3

6 years ago
Created attachment 570955 [details] [diff] [review]
Patch

The real patch this time
Attachment #570953 - Attachment is obsolete: true
Attachment #570953 - Flags: review?(roc)
Attachment #570955 - Flags: review?(roc)
Can you explain what the bug is and why this fixes it?
(Assignee)

Comment 5

6 years ago
Created attachment 571496 [details] [diff] [review]
Patch v.2

Putting a description of the bug into words made me realize that there is a simpler fix for it :)

What was happening was that when a bidi continuation in an element with unicode-bidi: -moz-isolate crossed a column break, we were passing the saved mPrevFrame from the previous column in the subparagraph into AdvanceLineIteratorToFrame, even though we had meanwhile created a new nsBlockInFlowLineIterator for the new column.

The new patch zeros out the mPrevFrame in the subparagraph as well as the containing paragraph when creating the new line iterator.
Attachment #570955 - Attachment is obsolete: true
Attachment #570955 - Flags: review?(roc)
Attachment #571496 - Flags: review?(roc)
Attachment #571496 - Flags: review?(roc) → review+
(Assignee)

Comment 6

6 years ago
Comment on attachment 571496 [details] [diff] [review]
Patch v.2

https://hg.mozilla.org/integration/mozilla-inbound/rev/3025c93444a6
Attachment #571496 - Flags: checkin+
(Assignee)

Updated

6 years ago
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/3025c93444a6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.