Closed Bug 695947 Opened 12 years ago Closed 12 years ago

[Linux PGO] Intermittent test_webgl_conformance_test_suite.html | Test failed, "successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined" (URL: conformance/glsl/variables/*.html)

Categories

(Core :: Graphics: CanvasWebGL, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=6943195&tree=Mozilla-Inbound
Rev3 Fedora 12 mozilla-inbound pgo test mochitests-1/5 on 2011-10-19 19:09:48 PDT for push 2d649d1cc360

WebGL mochitest: starting page conformance/glsl/variables/gl-fragcoord.html
ResizeOffscreenFBO failed with AA, retrying without...
ResizeOffscreenFBO failed with AA, retrying without...
45996 ERROR TEST-UNEXPECTED-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | Test failed, "successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined" (URL: conformance/glsl/variables/gl-fragcoord.html)
WebGL test error: test page failure: conformance/glsl/variables/gl-fragcoord.html
WebGL mochitest: starting page conformance/glsl/variables/gl-frontfacing.html
ResizeOffscreenFBO failed with AA, retrying without...
ResizeOffscreenFBO failed with AA, retrying without...
45997 ERROR TEST-UNEXPECTED-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | Test failed, "successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined" (URL: conformance/glsl/variables/gl-frontfacing.html)
WebGL test error: test page failure: conformance/glsl/variables/gl-frontfacing.html
Summary: Intermittent test_webgl_conformance_test_suite.html | Test failed, "successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined" (URL: conformance/glsl/variables/gl-fragcoord.html and gl-frontfacing.html) → [Linux 32bit PGO] Intermittent test_webgl_conformance_test_suite.html | Test failed, "successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined" (URL: conformance/glsl/variables/*.html)
Jeff had the idea that this could be caused by the slaves running out of (video) memory, which fits well with the fact that the JS engine tends to keep unreferenced WebGL contexts around very long before GCing (see bug 617453). This patch triggers a GC before starting every webgl test page.

on try:
https://tbpl.mozilla.org/?tree=Try&rev=a3d9424c6296

retrigger a dozen times to check if it fixes the problem.
Summary: [Linux 32bit PGO] Intermittent test_webgl_conformance_test_suite.html | Test failed, "successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined" (URL: conformance/glsl/variables/*.html) → [Linux PGO] Intermittent test_webgl_conformance_test_suite.html | Test failed, "successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined" (URL: conformance/glsl/variables/*.html)
(In reply to Benoit Jacob [:bjacob] from comment #5)
> didn't have PGO enabled. new try:
> https://tbpl.mozilla.org/?tree=Try&rev=789cf49fdc63

All green after 12 retriggers. Will land tomorrow.
(In reply to TinderboxPushlog Robot from comment #6)
> philor
> https://tbpl.mozilla.org/php/getParsedLog.php?id=6979443&tree=Mozilla-Inbound
> Rev3 Fedora 12x64 mozilla-inbound pgo test mochitests-1/5 on 2011-10-21

Very interesting to see that it also happens on 64bit slaves. Will update patch accordingly.
http://hg.mozilla.org/mozilla-central/rev/a0784cecf9bd

Keeping this bug open until the next m-c -> m-i merge
(In reply to Benoit Jacob [:bjacob] from comment #9)
> http://hg.mozilla.org/mozilla-central/rev/a0784cecf9bd
> 
> Keeping this bug open until the next m-c -> m-i merge

that's not needed and easy to miss, indeed it already happened. Landing on m-c should immediately mark bugs as fixed, they can always be reopened indeed.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to Marco Bonardo [:mak] from comment #10)
> (In reply to Benoit Jacob [:bjacob] from comment #9)
> > http://hg.mozilla.org/mozilla-central/rev/a0784cecf9bd
> > 
> > Keeping this bug open until the next m-c -> m-i merge
> 
> that's not needed and easy to miss, indeed it already happened. Landing on
> m-c should immediately mark bugs as fixed, they can always be reopened
> indeed.

This is a special case: this bug and bug 696009 have been used to star very frequent intermittent oranges. Having them marked as fixed before oranges were completely gone on inbound could have confused people trying to star oranges there. I was not going to forget about it. Thanks for closing though.
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.