696062 - Clear History

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Doug Turner (:dougt)]

Need a way to clear all history and bookmarks

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Since we are using the system data stores, would we be clearing _all_ history (Firefox and Webkit) ?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 569612 [details] [diff] [review]
patch


ConfirmPreference.java

Do we really need this for prompt confirmations in preferences? I guess there really isn't a way to use DialogPreference directly.

>diff --git a/embedding/android/locales/en-US/android_strings.dtd b/embedding/android/locales/en-US/android_strings.dtd

>+<!ENTITY pref_clear_history "Clear History">

"Clear history"

>+<!ENTITY pref_clear_history_confirm "Are you sure you want to clear your browsing history?">

Seems too wordy. How about:

"Browsing history will be deleted"

>+<!ENTITY pref_clear_history_yes "Yes, clear my history">
>+<!ENTITY pref_clear_history_no "No, cancel">

Let's just use "Yes" and "No" - Can we get those for free from the system resources?

>diff --git a/embedding/android/resources/xml/preferences.xml b/embedding/android/resources/xml/preferences.xml
>--- a/embedding/android/resources/xml/preferences.xml
>+++ b/embedding/android/resources/xml/preferences.xml
>@@ -53,4 +53,13 @@
> 
>     </PreferenceCategory>
> 
>+    <PreferenceCategory android:title="@string/pref_category_history">

Let's just put this in "Privacy & Security" group. Add it as the first item in that group.

We'll need to cleanup the ordering and groups in general, but that is a different bug.


BTW, does using "Browser" convenience methods like this cause things like bug 697360 ?

r+ with the nits fixed

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/457c61dd975b

Comment 5

[Catalin Suciu [:csuciu]]

Verified fixed on the latest fennec native build:
Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111122 Firefox/11.0a1 Fennec/11.0a1
Samsung GalaxyS, Android 2.2