Closed Bug 696187 Opened 9 years ago Closed 9 years ago

Don't harcode the appID in nsAndroidStartup.cpp

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: fabrice, Assigned: fabrice)

References

Details

(Whiteboard: [QA?])

Attachments

(1 file)

Attached patch patchSplinter Review
Since nsAndroidStartup.cpp is not using application.ini anymore, I moved the application ID into mobile/confvars.sh

The patch also updates the application filter for the BrowserCLH component.
Attachment #568487 - Flags: review?(doug.turner)
Comment on attachment 568487 [details] [diff] [review]
patch

this looks okay, but lets let ted look over it.
Attachment #568487 - Flags: review?(doug.turner) → review?(ted.mielczarek)
Whiteboard: [QA?]
Comment on attachment 568487 [details] [diff] [review]
patch

Review of attachment 568487 [details] [diff] [review]:
-----------------------------------------------------------------

Would you like to fix desktop Firefox to use this as well, for consistency?

::: mobile/components/MobileComponents.manifest
@@ +72,4 @@
>  category wakeup-request PromptService @mozilla.org/embedcomp/prompt-service;1,nsIPromptService,getService,Prompt:Call
>  
>  # BrowserCLH.js
> +component {be623d20-d305-11de-8a39-0800200c9a66} BrowserCLH.js application={aa3c5121-dab2-40e2-81ca-7ea25febc110}

Did this just not get updated with the new Fennec App ID?
Attachment #568487 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → fabrice
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.