Closed
Bug 696187
Opened 14 years ago
Closed 14 years ago
Don't harcode the appID in nsAndroidStartup.cpp
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fabrice, Assigned: fabrice)
References
Details
(Whiteboard: [QA?])
Attachments
(1 file)
|
3.41 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Since nsAndroidStartup.cpp is not using application.ini anymore, I moved the application ID into mobile/confvars.sh
The patch also updates the application filter for the BrowserCLH component.
|
Assignee | |
Updated•14 years ago
|
Attachment #568487 -
Flags: review?(doug.turner)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 568487 [details] [diff] [review]
patch
this looks okay, but lets let ted look over it.
Attachment #568487 -
Flags: review?(doug.turner) → review?(ted.mielczarek)
|
||
Updated•14 years ago
|
Whiteboard: [QA?]
|
||
Comment 2•14 years ago
|
||
Comment on attachment 568487 [details] [diff] [review]
patch
Review of attachment 568487 [details] [diff] [review]:
-----------------------------------------------------------------
Would you like to fix desktop Firefox to use this as well, for consistency?
::: mobile/components/MobileComponents.manifest
@@ +72,4 @@
> category wakeup-request PromptService @mozilla.org/embedcomp/prompt-service;1,nsIPromptService,getService,Prompt:Call
>
> # BrowserCLH.js
> +component {be623d20-d305-11de-8a39-0800200c9a66} BrowserCLH.js application={aa3c5121-dab2-40e2-81ca-7ea25febc110}
Did this just not get updated with the new Fennec App ID?
Attachment #568487 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Updated•14 years ago
|
Assignee: nobody → fabrice
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•