696235 - Set STAT_TTL > 1 in Bugzilla::Template->create

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Frédéric Buclin]

As explained in the TT documentation (see the URL above), Template::Provider keeps a copy of a template in memory for 1 second only by default. When using mod_perl (but also with mod_cgi), this time should be set to a higher value, e.g. 30 or 60 seconds, as a production installation doesn't edit its templates very often. This time is controlled by the STAT_TTL parameter which can be set in Bugzilla::Template->create.

dkl will do some benchmarking for us.

Comment 1

[Max Kanat-Alexander]

That wouldn't help us any differently on mod_perl than it would on mod_cgi. Templates are kept in memory only for the lifetime of the template object, which is re-created on every request. Persisting a template object across many requests would be both very tricky and also likely to not gain us much.

However, if there are times when, during a single request, a template is likely to be used after 1 second, that seems reasonable. In fact, I think we could set STAT_TTL to an infinitely high value (or whatever means "keep this in memory forever until we throw you away").

Comment 2

[Frédéric Buclin]

(In reply to Max Kanat-Alexander from comment #1)
> However, if there are times when, during a single request, a template is
> likely to be used after 1 second, that seems reasonable.

Mass-change and show multiple bugs at once are cases where the same template is reused several times, and where the time to complete is much longer than one second. And bugs with many comments can take more than one second too, and so the comment template is reloaded several times. The benefit is probably not very high, but this doesn't hurt.

Comment 3

[Frédéric Buclin]

Fixed by blocker.