[static ctor]static constructor in nsFSDR.cpp

VERIFIED WONTFIX

Status

Core Graveyard
Security: UI
VERIFIED WONTFIX
17 years ago
a year ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

1.0 Branch
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

17 years ago
in extensions/psm-glue/src/nsFSDR.cpp there is a global variable

nsAutoString gKey;

This causes static construction, which is bad because it causes portability
problems on some platforms (e.g., OpenBSD) and also leads to shutdown ordering
issues.  See <URL: http://www.mozilla.org/hacking/portable-cpp.html >.  (This
should also be an nsString rather than an nsAutoString.)

Comment 1

17 years ago
Reporter, is this still a problem now that PSM 2.0 is integrated into the 
nightly builds?
(Assignee)

Comment 2

17 years ago
Not if extensions/psm-glue/ isn't built anymore, although I'd like to see the
file cvs removed before closing it, and also like to check that the code wasn't
just copied elsewhere.

Comment 3

17 years ago
psm-glue is no longer built. Marking WONTFIX.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → WONTFIX

Comment 4

17 years ago
Verified per dddrinan's comments.
Status: RESOLVED → VERIFIED

Comment 5

17 years ago
Mass changing Security:Crypto to PSM
Component: Security: Crypto → Client Library
Product: Browser → PSM
Version: other → 2.1

Comment 6

17 years ago
Mass changing Security:Crypto to PSM

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.