Valgrind job isn't using our suppressions file

VERIFIED FIXED in mozilla15

Status

P3
normal
VERIFIED FIXED
7 years ago
a year ago

People

(Reporter: jruderman, Assigned: emorley)

Tracking

Trunk
mozilla15
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [valgrind])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=6905176&full=1&branch=mozilla-central#error0

args: ['/usr/bin/valgrind', '--error-exitcode=1', '--smc-check=all', '--gen-suppressions=all', '--leak-check=full', '--num-callers=50', '/builds/slave/m-cen-lnx64-valgrind/objdir/dist/firefox/firefox-bin', '-no-remote', '-profile', '/builds/slave/m-cen-lnx64-valgrind/objdir/_profile/pgo/pgoprofile/', 'http://localhost:8888/index.html']

(Note the lack of --suppressions=...)

Did we switch architectures since adding the suppressions file bug 631841? Or did bug 672046 break something?
(Reporter)

Updated

7 years ago
Blocks: 696305
Priority: -- → P3
Component: Release Engineering → Release Engineering: Automation
Priority: P3 → --
QA Contact: release → catlee
Whiteboard: [valgrind]
Depends on: 696299
Priority: -- → P3
catlee, I looked in the log of:

https://tbpl.mozilla.org/php/getParsedLog.php?id=11226203&full=1&branch=mozilla-central

and there's still no --suppressions=<some .sup file> parameter. This portion of the patch in http://hg.mozilla.org/build/tools/rev/2bb5034bfca5 , it detects the suppression file at the correct location, no?

-suppression_file=_valgrind/${MACHTYPE}.sup
+suppression_file=$PWD/_valgrind/${MACHTYPE}.sup
 if [ -f $suppression_file ]; then
     debugger_args="$debugger_args --suppressions=$suppression_file"
 fi

Original patch was in bug 631841 comment 6.
I'm probably just speculating, but could it be that the .sup file exits, but the path is incorrect?
bug 672046 broke this. We AC_SUBST(MOZ_VALGRIND) in configure.in, but we don't have a line for that in autoconf.mk.in, so it's not actually set as a Makefile var.
(Assignee)

Comment 4

7 years ago
Created attachment 618998 [details] [diff] [review]
Patch v1
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #618998 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

7 years ago
Component: Release Engineering: Automation (General) → Build Config
Product: mozilla.org → Core
QA Contact: catlee → build-config
Version: other → Trunk
(Assignee)

Comment 5

7 years ago
Sorry for breaking this! :-s
Attachment #618998 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/f769cc9bd71c
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
This morning's build looks good:
https://tbpl.mozilla.org/php/getParsedLog.php?id=11320168&full=1&branch=mozilla-central

args: ['/usr/bin/valgrind', '--error-exitcode=1', '--smc-check=all', '--gen-suppressions=all', '--leak-check=full', '--num-callers=50', '--suppressions=/builds/slave/m-cen-lnx-valgrind/objdir/_valgrind/i686-redhat-linux-gnu.sup', '/builds/slave/m-cen-lnx-valgrind/objdir/dist/firefox/firefox-bin', '-no-remote', '-profile', '/builds/slave/m-cen-lnx-valgrind/objdir/_profile/pgo/pgoprofile/', 'http://localhost:8888/index.html']
Status: RESOLVED → VERIFIED

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.