Closed Bug 696298 Opened 8 years ago Closed 7 years ago

Add a cross-architecture Valgrind suppressions file

Categories

(Release Engineering :: General, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: gkw)

References

Details

(Whiteboard: [valgrind])

Attachments

(2 files)

Adding the same thing to multiple files in mozilla/build/valgrind/ seems silly. We should have a file that's used for both 32-bit and 64-bit, in addition to the architecture-specific files. (Valgrind can accept multiple --suppressions= files.)
Blocks: 696305
Priority: -- → P3
Whiteboard: [valgrind]
Attached patch patchSplinter Review
Let's call it "cross-architecture.sup".
Assignee: nobody → gary
Status: NEW → ASSIGNED
Attachment #664260 - Flags: review?(catlee)
Attachment #664260 - Flags: review?(catlee) → review+
http://hg.mozilla.org/build/tools/rev/755e58ebc9d4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
This is causing:

{
scripts/scripts/valgrind/valgrind.sh: line 71: cross-architecture-suppression_file=/builds/slave/m-cen-lnx-valgrind/objdir/_valgrind/cross-architecture.sup: No such file or directory
}

https://tbpl.mozilla.org/php/getParsedLog.php?id=15516843&tree=Firefox
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Since bash doesn't like hyphens in variable names (roughly [a-z0-9A-Z_] and not starting with a digit).
Attachment #664521 - Flags: review?(catlee)
Attachment #664521 - Flags: review?(catlee) → review+
Comment on attachment 664521 [details] [diff] [review]
Replace hyphens with underscores in variable name

Thank you for the review :-)

http://hg.mozilla.org/build/tools/rev/b20f3a5f1220
Attachment #664521 - Flags: checked-in+
The build now succeeds (albeit is red and hits the max log size limit):
https://tbpl.mozilla.org/php/getParsedLog.php?id=15522943&tree=Firefox
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.