Closed
Bug 696298
Opened 10 years ago
Closed 9 years ago
Add a cross-architecture Valgrind suppressions file
Categories
(Release Engineering :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: gkw)
References
Details
(Whiteboard: [valgrind])
Attachments
(2 files)
1.26 KB,
patch
|
catlee
:
review+
|
Details | Diff | Splinter Review |
1.33 KB,
patch
|
catlee
:
review+
emorley
:
checked-in+
|
Details | Diff | Splinter Review |
Adding the same thing to multiple files in mozilla/build/valgrind/ seems silly. We should have a file that's used for both 32-bit and 64-bit, in addition to the architecture-specific files. (Valgrind can accept multiple --suppressions= files.)
Updated•10 years ago
|
Priority: -- → P3
Whiteboard: [valgrind]
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Let's call it "cross-architecture.sup".
Updated•9 years ago
|
Attachment #664260 -
Flags: review?(catlee) → review+
![]() |
Assignee | |
Comment 2•9 years ago
|
||
http://hg.mozilla.org/build/tools/rev/755e58ebc9d4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 3•9 years ago
|
||
And https://hg.mozilla.org/integration/mozilla-inbound/rev/13ae166abd45
Comment 5•9 years ago
|
||
This is causing: { scripts/scripts/valgrind/valgrind.sh: line 71: cross-architecture-suppression_file=/builds/slave/m-cen-lnx-valgrind/objdir/_valgrind/cross-architecture.sup: No such file or directory } https://tbpl.mozilla.org/php/getParsedLog.php?id=15516843&tree=Firefox
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•9 years ago
|
||
Since bash doesn't like hyphens in variable names (roughly [a-z0-9A-Z_] and not starting with a digit).
Updated•9 years ago
|
Attachment #664521 -
Flags: review?(catlee)
Updated•9 years ago
|
Attachment #664521 -
Flags: review?(catlee) → review+
Comment 7•9 years ago
|
||
Comment on attachment 664521 [details] [diff] [review] Replace hyphens with underscores in variable name Thank you for the review :-) http://hg.mozilla.org/build/tools/rev/b20f3a5f1220
Attachment #664521 -
Flags: checked-in+
Comment 8•9 years ago
|
||
The build now succeeds (albeit is red and hits the max log size limit): https://tbpl.mozilla.org/php/getParsedLog.php?id=15522943&tree=Firefox
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•