696298 - Add a cross-architecture Valgrind suppressions file

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Jesse Ruderman]

Adding the same thing to multiple files in mozilla/build/valgrind/ seems silly. We should have a file that's used for both 32-bit and 64-bit, in addition to the architecture-specific files. (Valgrind can accept multiple --suppressions= files.)

Comment 1

[Gary Kwong [:gkw] [:nth10sd]]

Attachment: patch

Let's call it "cross-architecture.sup".

Comment 2

[Gary Kwong [:gkw] [:nth10sd]]

http://hg.mozilla.org/build/tools/rev/755e58ebc9d4

Comment 3

[Jesse Ruderman]

And https://hg.mozilla.org/integration/mozilla-inbound/rev/13ae166abd45

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/13ae166abd45

Comment 5

[Ed Morley [:emorley]]

This is causing:

{
scripts/scripts/valgrind/valgrind.sh: line 71: cross-architecture-suppression_file=/builds/slave/m-cen-lnx-valgrind/objdir/_valgrind/cross-architecture.sup: No such file or directory
}

https://tbpl.mozilla.org/php/getParsedLog.php?id=15516843&tree=Firefox

Comment 6

[Ed Morley [:emorley]]

Attachment: Replace hyphens with underscores in variable name

Since bash doesn't like hyphens in variable names (roughly [a-z0-9A-Z_] and not starting with a digit).

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 664521 [details] [diff] [review]
Replace hyphens with underscores in variable name

Thank you for the review :-)

http://hg.mozilla.org/build/tools/rev/b20f3a5f1220

Comment 8

[Ed Morley [:emorley]]

The build now succeeds (albeit is red and hits the max log size limit):
https://tbpl.mozilla.org/php/getParsedLog.php?id=15522943&tree=Firefox