696311 - Show current url in awesomebar when you tap it.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch v1

We're calling the wrong method when you tap the awesomebar, so the current url isn't being filled in. This fixes that, and abstracts things a little bit to combine some duplicate code.

Comment 1

[Lucas Rocha (:lucasr)]

Comment on attachment 568597 [details] [diff] [review]
Patch v1

Review of attachment 568597 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/GeckoApp.java
@@ +954,5 @@
>          intent.addFlags(Intent.FLAG_ACTIVITY_NO_ANIMATION | Intent.FLAG_ACTIVITY_NO_HISTORY);
> +        intent.putExtra(AwesomeBar.TYPE_KEY, aType.name());
> +        // if we're adding a new tab, we don't want to show the old url
> +        if (aType != AwesomeBar.Type.ADD) {
> +            Tab tab = Tabs.getInstance().getSelectedTab();

Shouldn't the comment about new tabs actually be here?

@@ +956,5 @@
> +        // if we're adding a new tab, we don't want to show the old url
> +        if (aType != AwesomeBar.Type.ADD) {
> +            Tab tab = Tabs.getInstance().getSelectedTab();
> +            if (!tab.getHistory().empty()) {
> +                intent.putExtra(AwesomeBar.CURRENT_URL_KEY, tab.getHistory().peek().mUri);

This is a lot of chained calls :-) No big deal though.

@@ +962,2 @@
>          }
>          startActivityForResult(intent, AWESOMEBAR_REQUEST);

Not on your patch but I wonder why showAwesomebar returns a boolean if it always returns true.

Comment 3

[Sriram Ramasubramanian [:sriram]]

All this is not needed. There is already a function taking care of this. I'll upload a new patch.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Sorry. This is a better patch. :)

Comment 5

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/projects/birch/rev/73556e76e3cb

Comment 6

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111025 Firefox/10.0a1 Fennec/10.0a1