696352 - required fields have broken colors

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect, P3)

Description

[Michal 'hramrach' Suchanek]

Attachment: screenshot-20111021134920.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20100101 Firefox/7.0.1 Iceweasel/7.0.1
Build ID: 20111004070756

Steps to reproduce:

Report new bug.


Actual results:

Required fields are unreadable.


Expected results:

bugzilla has correct HTML

Comment 1

[Frédéric Buclin]

This is only a problem with non-standard colors.

Comment 2

[David Lawrence [:dkl]]

Of course I do not see the same colors when I view the enter_bug.cgi page. Are you using some sort of desktop theme with your OS that causes different interface elements to have the green color and also changing the color of the text? If so, it would be difficult for us to create a color choice that would satisfy everyone when the desktop is making it's own choices. Does the page still look bad when choosing a more neutral theme?

dkl

Comment 3

[Michal 'hramrach' Suchanek]

There are no standard or neutral colors.

My theme is completely fine, it shows light text on dark background.

Your HTML is bogus, it shows undefined text on light background.

When combined with my theme the undefined color becomes light resulting in light text on light background.

Comment 4

[Michal 'hramrach' Suchanek]

https://landfill.bugzilla.org/bugzilla-4.0-branch/skins/standard/global.css?1299744248 line 493 has the following code:

input.required, select.required, span.required_explanation {
    background-color: #FFF7CD;
}

you probably also want

input.required, select.required {
    color: black;
}

Comment 5

[Michal 'hramrach' Suchanek]

Attachment: patch to the file that looks like the bogus stylesheet

Don't have a bugzilla installation so it's untested.

Comment 6

[Christopher Trom]

(In reply to Michal 'hramrach' Suchanek from comment #5)
> Created attachment 582819 [details] [diff] [review]
> patch to the file that looks like the bogus stylesheet
> 
> Don't have a bugzilla installation so it's untested.

How did you pick the #300 color?

Comment 7

[Michal 'hramrach' Suchanek]

(In reply to Christopher from comment #6)
> (In reply to Michal 'hramrach' Suchanek from comment #5)
> > Created attachment 582819 [details] [diff] [review]
> > patch to the file that looks like the bogus stylesheet
> > 
> > Don't have a bugzilla installation so it's untested.
> 
> How did you pick the #300 color?

At random.

You can change it to something else if you don't like it.

It should be clearly visible on the background set in the style, though.

Comment 8

[Frédéric Buclin]

Comment on attachment 582819 [details] [diff] [review]
patch to the file that looks like the bogus stylesheet

Let's use the same color for span.required_explanation, which means both blocks can be merged. Also, let's use black instead of #300, which was chosen randomly, as you said in your previous comment.

Do you want to update your patch, or should we do it ourselves?

Comment 9

[Michal 'hramrach' Suchanek]

Attachment: updated patch

If you prefer to randomly pick #000 than #300 then go for it.

Also note that span.required_explanation inherits color from body so it does not need color set.

But if you want to set color on it then there is no need for separate block.

Comment 10

[Frédéric Buclin]

Comment on attachment 598830 [details] [diff] [review]
updated patch

>+    color #000;

Missing colon after color. Must be color: #000. This can be fixed on checkin. Thank you for your contribution. r=LpSolit

Comment 11

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified skins/standard/global.css
Committed revision 8128.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified skins/standard/global.css
Committed revision 8036.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified skins/standard/global.css
Committed revision 7698.