Last Comment Bug 696437 - Add Gfx AppNotes for mobile
: Add Gfx AppNotes for mobile
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla10
Assigned To: Benoit Girard (:BenWa)
:
Mentors:
Depends on:
Blocks: opengl-mobile
  Show dependency treegraph
 
Reported: 2011-10-21 11:35 PDT by Benoit Girard (:BenWa)
Modified: 2011-11-03 08:27 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.45 KB, patch)
2011-11-01 08:03 PDT, Benoit Girard (:BenWa)
jacob.benoit.1: review+
Details | Diff | Splinter Review

Description Benoit Girard (:BenWa) 2011-10-21 11:35:43 PDT

    
Comment 1 Benoit Girard (:BenWa) 2011-11-01 06:57:31 PDT
Testing:
Run with '--es env0 MOZ_CRASHREPORTER=1'
adb shell run-as org.mozilla.fennec_benoitgirard kill -6 <PID>
(6 is SIGABRT)
Comment 2 Benoit Girard (:BenWa) 2011-11-01 08:03:29 PDT
Created attachment 571002 [details] [diff] [review]
patch

I wonder if we should also print the GL extensions?
Comment 3 Benoit Girard (:BenWa) 2011-11-01 08:04:37 PDT
Sample report:
http://crash-stats.mozilla.com/report/index/bp-c9df5898-8cad-4431-ae15-a153f2111101
Comment 4 Benoit Jacob [:bjacob] (mostly away) 2011-11-01 12:59:39 PDT
Comment on attachment 571002 [details] [diff] [review]
patch

Review of attachment 571002 [details] [diff] [review]:
-----------------------------------------------------------------

r=me provided that you remove those debug printfs.

::: widget/src/android/GfxInfo.cpp
@@ +222,2 @@
>  {
> +  printf_stderr("Crash notes start\n");

remove those printfs, they look like a leftover from debugging.
Comment 6 Marco Bonardo [::mak] (Away 6-20 Aug) 2011-11-03 08:27:11 PDT
https://hg.mozilla.org/mozilla-central/rev/98892c213475

Note You need to log in before you can comment on or make changes to this bug.