Closed Bug 696462 Opened 8 years ago Closed 8 years ago

Ux Designs for Tab Lists

Categories

(Firefox for Android :: General, defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- verified
fennec 11+ ---

People

(Reporter: elan, Assigned: sriram)

References

Details

(Whiteboard: [QA+])

Attachments

(5 files, 1 obsolete file)

Meta bug.
Whiteboard: [QA+]
Assignee: nobody → madhava
More polished mocks and assets are on the way, but this should be enough to start with.
Attached image Tab menu specs
Attached patch PatchSplinter Review
This patch adds the functionality as required.
The system colors are used while pressing the list entry and close button.
Everything has been moved to a new activity as there were issues when lists were shown in a PopupWindow.
There is no loss of UX functionality with this approach.
The TabsTray listens for Tab change events in GeckoApp. I would like to hold the listening functionality in GeckoApp and there might be race conditions if TabsTray had to listen to GeckoEvents directly.

Things to do:
1. A divider at the end of the list.
2. Bolden the selected tab.
3. A grow_in, shrink_out animation to give the native PopupWindow feel - the system animations are private and hence requires us to define them again.

I would like to address them as follow up bugs.

Only one set of images are added with this patch. The whole set will be added based on the resolution taken here: http://bugzil.la/696832
Attachment #571394 - Flags: review?(mark.finkle)
This patch adds a divider before add-tab button.
A new LinearLayout is inflated during creation. It takes the height of the list's divider and applying the divider as the background.
This works fine for most cases (and this is the only way I could think of).

Other options tried:
1. Adding the add-tab as footer gets hidden when the list becomes scrollable. This is not as per UI spec.
2. Adding a LinearLayout with divider's background fails -- as the divider resource is not public.

Problems seen:
1. The screen refresh (actual phone's refreshing) seems to cause some issues. The divider goes away after sometime in Droid pro.
2. When the user presses on the add-tab and moves away from the list without clicking on it (mouse-down on add-tab, mouse-up outside add-tab), the selection color shows up and removes the LinearLayout.

If these issues are fine, this approach works for most cases.
Assignee: madhava → sriram
Attachment #571507 - Flags: review?(mark.finkle)
Comment on attachment 571507 [details] [diff] [review]
Patch 2: Adding a divider before add-tab

If we see issues, we should file new bugs
Attachment #571507 - Flags: review?(mark.finkle) → review+
Attachment #571394 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/projects/birch/rev/20a2ecb0593d
https://hg.mozilla.org/projects/birch/rev/b6b31c4fc286

these patches do not add the 'bold' style to the selected tab. please open a new bug for that issue.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 699394
20111103040334
http://hg.mozilla.org/projects/birch/rev/c09a52af4cd8
Samsung Nexus S (Android 2.3.6)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
You need to log in before you can comment on or make changes to this bug.