696462 - Ux Designs for Tab Lists

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Erin Lancaster [:elan]]

Meta bug.

Comment 1

[Ian Barlow (:ibarlow)]

Attachment: Wire-mocks of tab interactions

More polished mocks and assets are on the way, but this should be enough to start with.

Comment 2

[Ian Barlow (:ibarlow)]

Attachment: Tab menu specs

Comment 3

[Ian Barlow (:ibarlow)]

Attachment: Graphic assets for menus for Froyo, Gingerbread, ICS, at a multitude of pixel densities

Comment 4

[Ian Barlow (:ibarlow)]

Attachment: Graphic assets for menus for Froyo, Gingerbread, ICS, at a multitude of pixel densities

Comment 5

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch adds the functionality as required.
The system colors are used while pressing the list entry and close button.
Everything has been moved to a new activity as there were issues when lists were shown in a PopupWindow.
There is no loss of UX functionality with this approach.
The TabsTray listens for Tab change events in GeckoApp. I would like to hold the listening functionality in GeckoApp and there might be race conditions if TabsTray had to listen to GeckoEvents directly.

Things to do:
1. A divider at the end of the list.
2. Bolden the selected tab.
3. A grow_in, shrink_out animation to give the native PopupWindow feel - the system animations are private and hence requires us to define them again.

I would like to address them as follow up bugs.

Only one set of images are added with this patch. The whole set will be added based on the resolution taken here: http://bugzil.la/696832

Comment 6

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch 2: Adding a divider before add-tab

This patch adds a divider before add-tab button.
A new LinearLayout is inflated during creation. It takes the height of the list's divider and applying the divider as the background.
This works fine for most cases (and this is the only way I could think of).

Other options tried:
1. Adding the add-tab as footer gets hidden when the list becomes scrollable. This is not as per UI spec.
2. Adding a LinearLayout with divider's background fails -- as the divider resource is not public.

Problems seen:
1. The screen refresh (actual phone's refreshing) seems to cause some issues. The divider goes away after sometime in Droid pro.
2. When the user presses on the add-tab and moves away from the list without clicking on it (mouse-down on add-tab, mouse-up outside add-tab), the selection color shows up and removes the LinearLayout.

If these issues are fine, this approach works for most cases.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 571507 [details] [diff] [review]
Patch 2: Adding a divider before add-tab

If we see issues, we should file new bugs

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/20a2ecb0593d
https://hg.mozilla.org/projects/birch/rev/b6b31c4fc286

these patches do not add the 'bold' style to the selected tab. please open a new bug for that issue.

Comment 9

[Aaron Train [:aaronmt]]

20111103040334
http://hg.mozilla.org/projects/birch/rev/c09a52af4cd8
Samsung Nexus S (Android 2.3.6)