Closed
Bug 696478
Opened 13 years ago
Closed 13 years ago
observer not being removed in nsFormAutoComplete
Categories
(Toolkit :: Form Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file)
|
1.95 KB,
patch
|
mak
:
review+
espindola
:
checkin+
|
Details | Diff | Splinter Review |
in nsFormAutoComplete.js we have
this._prefBranch.addObserver("", this.observer, false);
but no call to removeObselver matching it
|
Assignee | |
Comment 1•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=d2c627816830
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #570818 -
Flags: review?(mak77)
Attachment #570818 -
Flags: feedback?(honzab.moz)
|
||
Updated•13 years ago
|
Attachment #570818 -
Flags: review?(mak77)
Attachment #570818 -
Flags: review+
Attachment #570818 -
Flags: feedback?(honzab.moz)
|
|
||
Updated•13 years ago
|
Summary: observer not being removed → observer not being removed in nsFormAutoComplete
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 570818 [details] [diff] [review] Use weak ownership https://hg.mozilla.org/integration/mozilla-inbound/rev/0297168cbf92
Attachment #570818 -
Flags: checkin+
|
||
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0297168cbf92
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•