Closed Bug 696495 Opened 8 years ago Closed 8 years ago

texture-mips.html failures might be workaroundable by setting minification filter before glGenerateMipmap call

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

Attachments

(2 files)

See bug 695272 for an intermittent failure we've seen on linux. This is also permanently failing on mac.

See http://code.google.com/p/chromium/issues/detail?id=101105 for a possible workaround.

Thanks to Ken at Google.
Attached patch workaroundSplinter Review
This is similar to http://codereview.chromium.org/8365018/

Tryserver push not ignoring this texture-mips test or assuming it to fail anywhere:
https://tbpl.mozilla.org/?tree=Try&rev=33979feed4f6
Comment on attachment 568790 [details] [diff] [review]
workaround

I'd like to land that now. It's still fixing test failures on the slaves.
Attachment #568790 - Flags: review?(jgilbert)
Attachment #568790 - Flags: review?(jgilbert) → review+
We should also bother driver vendors about this.
http://hg.mozilla.org/integration/mozilla-inbound/rev/23ec123586ba
Assignee: nobody → bjacob
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla12
backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7030a479b0e3

at this point it looks like this is not needed.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Results on webgl-driver-testing show that this seems really needed for many users on Windows with NVIDIA driver, even though this is somehow not needed on our test slaves.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Attached patch updatedSplinter Review
updated, check WorkAroundDriverBugs(). carrying forward r+.

https://tbpl.mozilla.org/?tree=Try&rev=05b4b75b9f22
Attachment #616552 - Flags: review+
Comment on attachment 616552 [details] [diff] [review]
updated

Please approve for mozilla-central. Needed for WebGL conformance on real-world drivers. Very safe. Only affects WebGL, which is not a priority for the upcoming Android release.
Attachment #616552 - Flags: approval-mozilla-central?
Attachment #616552 - Flags: approval-mozilla-central? → approval-mozilla-central+
http://hg.mozilla.org/integration/mozilla-inbound/rev/eb53fd368324
Status: REOPENED → ASSIGNED
Target Milestone: mozilla12 → mozilla14
https://hg.mozilla.org/mozilla-central/rev/eb53fd368324
Status: ASSIGNED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Blocks: 750564
You need to log in before you can comment on or make changes to this bug.