696495 - texture-mips.html failures might be workaroundable by setting minification filter before glGenerateMipmap call

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

See bug 695272 for an intermittent failure we've seen on linux. This is also permanently failing on mac.

See http://code.google.com/p/chromium/issues/detail?id=101105 for a possible workaround.

Thanks to Ken at Google.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: workaround

This is similar to http://codereview.chromium.org/8365018/

Tryserver push not ignoring this texture-mips test or assuming it to fail anywhere:
https://tbpl.mozilla.org/?tree=Try&rev=33979feed4f6

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 568790 [details] [diff] [review]
workaround

I'd like to land that now. It's still fixing test failures on the slaves.

Comment 3

[Kelsey Gilbert [:jgilbert]]

We should also bother driver vendors about this.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/23ec123586ba

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7030a479b0e3

at this point it looks like this is not needed.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/23ec123586ba
https://hg.mozilla.org/mozilla-central/rev/7030a479b0e3

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Results on webgl-driver-testing show that this seems really needed for many users on Windows with NVIDIA driver, even though this is somehow not needed on our test slaves.

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: updated

updated, check WorkAroundDriverBugs(). carrying forward r+.

https://tbpl.mozilla.org/?tree=Try&rev=05b4b75b9f22

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 616552 [details] [diff] [review]
updated

Please approve for mozilla-central. Needed for WebGL conformance on real-world drivers. Very safe. Only affects WebGL, which is not a priority for the upcoming Android release.

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/eb53fd368324

Comment 11

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/eb53fd368324