texture-mips.html failures might be workaroundable by setting minification filter before glGenerateMipmap call

RESOLVED FIXED in mozilla14

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

unspecified
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

See bug 695272 for an intermittent failure we've seen on linux. This is also permanently failing on mac.

See http://code.google.com/p/chromium/issues/detail?id=101105 for a possible workaround.

Thanks to Ken at Google.
(Assignee)

Comment 1

6 years ago
Created attachment 568790 [details] [diff] [review]
workaround

This is similar to http://codereview.chromium.org/8365018/

Tryserver push not ignoring this texture-mips test or assuming it to fail anywhere:
https://tbpl.mozilla.org/?tree=Try&rev=33979feed4f6
(Assignee)

Comment 2

6 years ago
Comment on attachment 568790 [details] [diff] [review]
workaround

I'd like to land that now. It's still fixing test failures on the slaves.
Attachment #568790 - Flags: review?(jgilbert)
Attachment #568790 - Flags: review?(jgilbert) → review+
We should also bother driver vendors about this.
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/23ec123586ba
Assignee: nobody → bjacob
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla12
(Assignee)

Comment 5

6 years ago
backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7030a479b0e3

at this point it looks like this is not needed.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
https://hg.mozilla.org/mozilla-central/rev/23ec123586ba
https://hg.mozilla.org/mozilla-central/rev/7030a479b0e3
(Assignee)

Comment 7

5 years ago
Results on webgl-driver-testing show that this seems really needed for many users on Windows with NVIDIA driver, even though this is somehow not needed on our test slaves.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
(Assignee)

Comment 8

5 years ago
Created attachment 616552 [details] [diff] [review]
updated

updated, check WorkAroundDriverBugs(). carrying forward r+.

https://tbpl.mozilla.org/?tree=Try&rev=05b4b75b9f22
Attachment #616552 - Flags: review+
(Assignee)

Comment 9

5 years ago
Comment on attachment 616552 [details] [diff] [review]
updated

Please approve for mozilla-central. Needed for WebGL conformance on real-world drivers. Very safe. Only affects WebGL, which is not a priority for the upcoming Android release.
Attachment #616552 - Flags: approval-mozilla-central?

Updated

5 years ago
Attachment #616552 - Flags: approval-mozilla-central? → approval-mozilla-central+
http://hg.mozilla.org/integration/mozilla-inbound/rev/eb53fd368324
Status: REOPENED → ASSIGNED
Target Milestone: mozilla12 → mozilla14
https://hg.mozilla.org/mozilla-central/rev/eb53fd368324
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago5 years ago
Resolution: --- → FIXED
Blocks: 750564
You need to log in before you can comment on or make changes to this bug.