696593 - Video and audio controls should adjust their display based on dimensions using the onresize event

Status: RESOLVED WORKSFORME

(Toolkit :: Video/Audio Controls, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 689374 and bug 462117 are for adding specialized HTML5 audio/video controls for small-dimension media, but they rely on the size of the media when it is loaded.

It will be good to add an event handler for element.onresize so that we can adjust the controls when the elements are resized (instead of just when the page loads).

Comment 1

[Owen Coutts [:tallOwen]]

It seems that |onresize| is only fired for window elements (https://developer.mozilla.org/en-US/docs/DOM/element.onresize). A polling approach could be used. Is there a better event to be used?

Comment 2

[Mardeg]

Isn't this exactly what CSS @media queries are for?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

The implementation of element 'resize' events is at bug 227495, so that bug would need to be fixed before this one can use that approach.

However, you could try Mardeg's comment about using CSS media queries.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Bug 876426 added a "resizevideocontrols" event that we can use to fix this bug.

The changes will need to be made in /toolkit/content/widgets/videocontrols.xml.

Owen, would you like to work on this bug as well as bug 729111?

Comment 5

[Bukola Felicia Akinnadeju]

is this bug still available for fixing? i want to try it out

can it be assigned to me?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

I'm not exactly sure if this bug is still present, given it looks like bug 876426 would have fixed it. However in comment #4 I implied it wasn't fixed yet. @Bukola, do you want to try to put together a webpage that has a video on it that is resizable and see what is working well and what isn't working well?

Comment 7

[Bukola Felicia Akinnadeju]

Its okay if its been fixed, I recently worked on something related to video and audio control

Thats what drew my attention to the bug.

Comment 8

[ola-oluwa]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)

I'm not exactly sure if this bug is still present, given it looks like bug 876426 would have fixed it. However in comment #4 I implied it wasn't fixed yet. @Bukola, do you want to try to put together a webpage that has a video on it that is resizable and see what is working well and what isn't working well?

I am an outreachy applicant. How do i go about putting up a webpage for this please

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

This is now working for me. I tested with a local video and resized the element using explicit CSS width measurements via the Inspector. Hovering over the video added/removed control abilities as the video changed dimensions.