Last Comment Bug 696621 - Inadvertent global variable creation in mail/base/content/folderPane.js
: Inadvertent global variable creation in mail/base/content/folderPane.js
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Folder and Message Lists (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 11.0
Assigned To: Jonathan Kamens
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-22 20:38 PDT by Jonathan Kamens
Modified: 2011-11-14 07:10 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch to fix inadvertent global variables (2.74 KB, patch)
2011-10-22 20:42 PDT, Jonathan Kamens
squibblyflabbetydoo: review+
Details | Diff | Splinter Review

Description Jonathan Kamens 2011-10-22 20:38:58 PDT
An add-on which I recently wrote was fully reviewed,but the reviewer (Kent James) commented as follows:

Interesting little issue: We normally don't allow addons to add new unnamespaced global variables to global windows. However, running your addon causes several new names, including "acct" and "folderWithFlag" that comes from bugs in the core folderPane.js with code like this:

  for each (folderWithFlag in fixIterator(foldersWithFlag.enumerate()

which should be

 for each (let folderWithFlag in fixIterator(foldersWithFlag.enumerate()

I'm not sure if that code is ever run in standard TB 8 with the folder switch feature removed.  If it isn't, then technically your code does not meet our AMO standards. Hmmm... at least for now I'll ignore this.

The patch I'm about to attach (submitting the bug first to get the bug # so I can put it in the patch title) fixes the inadvertent global variable creations in folderPane.js.
Comment 1 Jonathan Kamens 2011-10-22 20:42:09 PDT
Created attachment 568923 [details] [diff] [review]
patch to fix inadvertent global variables
Comment 2 Jim Porter (:squib) 2011-11-08 21:29:44 PST
Comment on attachment 568923 [details] [diff] [review]
patch to fix inadvertent global variables

Review of attachment 568923 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about the delay on this. I was swamped with stuff leading up to the last release/merge. I ran with this for a while, and everything looks ok to me.
Comment 3 Mike Conley (:mconley) - (Needinfo me!) 2011-11-14 07:10:20 PST
Checked in as http://hg.mozilla.org/comm-central/rev/2320a8ec2c1e

Note You need to log in before you can comment on or make changes to this bug.