696625 - nsSSLIOLayerAddToSocket and many other functions do not check if NSS has already been shut down

Status: RESOLVED DUPLICATE of bug 1215267

(Core :: Security: PSM, defect, P3)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

1. Any function that uses nsNSSShutDownPreventionLock only on the main thread shoult have the nsNSSShutDownPreventionLock usage removed, as NSS can only be shut down on the main thread.

2. Any function that uses nsNSSShutDownPreventionLock off the main thread must check that NSS hasn't already been shut down before using any NSS functions.

Many functions (e.g. nsSSLIOLayerAddToSocket) do not do this, so we may have races between NSS shutdown and NSS usage.

Comment 1

[Dana Keeler (she/her) [:keeler]]

This work done to simplify NSS shutdown in mozilla-central made this no longer an issue.