696658 - Review Revision page should contain revision comment

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Thomas Schwecherl]

For better understanding of the kind of changes at a glance, the Review Revision page should contain the revision comment(s) near the text "Reviewing Revision xyz by JaneDoe." at the top of the page.

E.g. review page https://support.mozilla.com/en-US/kb/Firefox%20is%20already%20running%20but%20is%20not%20responding/review/17874 should contain Alice Wayman's comment for this revision and maybe all the other comments of unreviewed revisions till the current version. With that the reviewer can see what to expect without looking at the history page.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

+mentorbits

Comment 2

[Kumar Anirudha [:anistark]]

If it's still in development, and being a [good first bug], I would like to work on it. Could you please explain what exactly to do?

Comment 3

[Kadir Topal [:atopal]]

Here is how the review page looks today: http://note.io/1qkW24R

Here is how it should look like: http://note.io/1qkVZ9b

We are adding to that page the revision comment. We are also adding the information about revisions that have not been reviewed yet.

Comment 4

[Kumar Anirudha [:anistark]]

But these are not included in the development files. Right? Cause any search gives me search is unavailable.
Also, do we need like reviewer account to view the development changes? Cause I can't see the page that atopal showed given the fact that I ain't a reviewer.

Comment 5

[Kadir Topal [:atopal]]

Yeah, you need to to be a reviewer to see that. Regarding the other questions: I don't know, maybe Ricky can help, but he'll be on vacation for another week. Maybe this wasn't the best first bug.

Comment 6

[Kumar Anirudha [:anistark]]

I guess so :atopal  :D

Comment 7

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Any progress here?

Comment 8

[Safwan Rahman (:safwan)]

Attachment: Proposed PAtch

Hope this fix the Issue! :)

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/a494c371ddde8e06287ca63977e73524817d4a8f

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod. Thank you Safwan!

Comment 11

[Safwan Rahman (:safwan)]

Thanks @r1cky and @mythmon for supporting me to fix the bug. Its really my pleasure.

Topal, can you please verify if the patch really fix the issue? As I dont have reviewer power account, I can not check. Please check and verify this bug. :)

Comment 12

[Kadir Topal [:atopal]]

Thanks a lot for this, Safwan! There are two follow-ups. I have filed another bug for that: bug 1112507