Closed Bug 696759 Opened 14 years ago Closed 14 years ago

Change Highlighter's shortcut key to Ctrl/Cmd-Alt-i

Categories

(DevTools :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: rcampbell, Assigned: rcampbell)

Details

Attachments

(1 file)

change the key from ctrl/cmd-shift-i to ctrl/cmd-alt-i.
Attached patch alt keySplinter Review
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #569074 - Flags: review?(gavin.sharp)
I vaguely recall Ctrl+Alt shortcuts being reserved on Windows and/or Linux.
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #3) > I vaguely recall Ctrl+Alt shortcuts being reserved on Windows and/or Linux. That's correct.
Comment on attachment 569074 [details] [diff] [review] alt key For instance, with my German keyboard on Win XP, Alt+Ctrl+E is € and Alt+Ctrl+M is µ. Alt+Ctrl+I could have a similar meaning in other locales.
Attachment #569074 - Flags: review?(gavin.sharp) → review-
(In reply to Dão Gottwald [:dao] from comment #5) > Comment on attachment 569074 [details] [diff] [review] [diff] [details] [review] > alt key > > For instance, with my German keyboard on Win XP, Alt+Ctrl+E is € and > Alt+Ctrl+M is µ. Alt+Ctrl+I could have a similar meaning in other locales. ugh. right. (In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #2) > Why? Cmd-shift-I conflicts with DOM Inspector. Pretty sure Chrome uses Cmd-alt-I.
Ultimatively it's DOMi's responsibility to deal with this... and overriding a built-in shortcut when providing a similar feature is a legitimate outcome.
(In reply to Dão Gottwald [:dao] from comment #7) > Ultimatively it's DOMi's responsibility to deal with this... and overriding > a built-in shortcut when providing a similar feature is a legitimate outcome. Yep, it is and I applaud their continued use of their shortcut key. I just wish I could change one of them so I don't keep accidentally opening DOM inspector when I want to open the built-in highlighter. :)
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Resolution: FIXED → WONTFIX
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: