696759 - Change Highlighter's shortcut key to Ctrl/Cmd-Alt-i

Status: RESOLVED WONTFIX

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

change the key from ctrl/cmd-shift-i to ctrl/cmd-alt-i.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Attachment: alt key

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Why?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I vaguely recall Ctrl+Alt shortcuts being reserved on Windows and/or Linux.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Gavin Sharp (use [e-mail] for email) from comment #3)
> I vaguely recall Ctrl+Alt shortcuts being reserved on Windows and/or Linux.

That's correct.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 569074 [details] [diff] [review]
alt key

For instance, with my German keyboard on Win XP, Alt+Ctrl+E is € and Alt+Ctrl+M is µ. Alt+Ctrl+I could have a similar meaning in other locales.

Comment 6

[Rob Campbell [:rc] (:robcee)]

(In reply to Dão Gottwald [:dao] from comment #5)
> Comment on attachment 569074 [details] [diff] [review] [diff] [details] [review]
> alt key
> 
> For instance, with my German keyboard on Win XP, Alt+Ctrl+E is € and
> Alt+Ctrl+M is µ. Alt+Ctrl+I could have a similar meaning in other locales.

ugh. right.

(In reply to Gavin Sharp (use [e-mail] for email) from comment #2)
> Why?

Cmd-shift-I conflicts with DOM Inspector. Pretty sure Chrome uses Cmd-alt-I.

Comment 7

[Dão Gottwald [:dao]]

Ultimatively it's DOMi's responsibility to deal with this... and overriding a built-in shortcut when providing a similar feature is a legitimate outcome.

Comment 8

[Rob Campbell [:rc] (:robcee)]

(In reply to Dão Gottwald [:dao] from comment #7)
> Ultimatively it's DOMi's responsibility to deal with this... and overriding
> a built-in shortcut when providing a similar feature is a legitimate outcome.

Yep, it is and I applaud their continued use of their shortcut key.

I just wish I could change one of them so I don't keep accidentally opening DOM inspector when I want to open the built-in highlighter. :)