sftkdb_DeleteSecmodDB and sftkdb_AddSecmodDB should set error code if dbname is NULL or rw is false.

RESOLVED FIXED in 3.13.3

Status

P2
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: wtc, Assigned: wtc)

Tracking

3.13
3.13.3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Created attachment 569106 [details] [diff] [review]
Proposed patch

The proposed patch makes the change Bob suggested in bug 641052 comment 7 and
bug 641052 comment 10.

If dbname is NULL or rw is false, sftkdb_DeleteSecmodDB and sftkdb_AddSecmodDB
returns SECFailure without setting an error code.  The patch fixes that.
Attachment #569106 - Flags: review?(rrelyea)
(Assignee)

Updated

7 years ago
Target Milestone: 3.13.1 → 3.13.2

Comment 1

7 years ago
Comment on attachment 569106 [details] [diff] [review]
Proposed patch

r+ rrelyea
Attachment #569106 - Flags: review?(rrelyea) → review+
(Assignee)

Comment 2

7 years ago
Patch checked in on the NSS trunk (NSS 3.13.3).

Checking in sftkmod.c;
/cvsroot/mozilla/security/nss/lib/softoken/sftkmod.c,v  <--  sftkmod.c
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: 3.13.2 → 3.13.3
(Assignee)

Comment 3

7 years ago
Created attachment 598391 [details] [diff] [review]
Need to include "secerr.h"

I must have created the previous patch without even compiling
it.  Sorry.

Patch checked in on the NSS trunk (NSS 3.13.3).

Checking in sftkmod.c;
/cvsroot/mozilla/security/nss/lib/softoken/sftkmod.c,v  <--  sftkmod.c
new revision: 1.11; previous revision: 1.10
done
Attachment #598391 - Flags: review?(rrelyea)

Comment 4

7 years ago
Comment on attachment 598391 [details] [diff] [review]
Need to include "secerr.h"

r+ though I presume this is already checked in;).

bob
Attachment #598391 - Flags: review?(rrelyea) → review+
You need to log in before you can comment on or make changes to this bug.