Closed Bug 696846 Opened 8 years ago Closed 8 years ago

Checkbox labels are black on native dialogs

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wesj, Assigned: wesj)

Details

Attachments

(2 files)

Checkboxes currently show black text on a black background for me in Native Fennec. I tried to fix this originally by using a text appearance style in dialog_checkbox.xml. Apparently, I confused myself by comparing that with a separate experiment where I used checkbox.setTextAppearance(...). Things would be fine if we were not using Theme.Light.NoTitleBar for our main theme, but apparently it has problems with these...

I'm not sure the exact right solution. Patch coming that uses setTextAppearance.
Attached patch Patch v1Splinter Review
Patch. Eclipse tells me its very bad not to list layout_width and layout_height so I added them as well.
Assignee: nobody → wjohnston
Attachment #569152 - Flags: review?(sriram)
> Things
> would be fine if we were not using Theme.Light.NoTitleBar for our main
> theme, but apparently it has problems with these...
I believe we only really want the light theme for our content area. Perhaps we can take the default no titlebar theme and apply the light theme specifically to our surfaceview. Would that solve your problem?
Attached patch Alternate PatchSplinter Review
Yeah, this works as an alternative.
Attachment #569208 - Flags: review?(blassey.bugs)
Comment on attachment 569208 [details] [diff] [review]
Alternate Patch

Review of attachment 569208 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/resources/values/themes.xml
@@ +1,3 @@
>  <?xml version="1.0" encoding="utf-8"?>
>  <resources>
> +    <style name="GreyTheme" parent="@android:style/Theme.Black.NoTitleBar">

use Theme.NoTitleBar to pick up the device default (which will be dark on most phones)
Attachment #569208 - Flags: review?(blassey.bugs) → review+
wes - fixed?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111027 FIrefox/10.0a1 Fennec/10.0a1
Status: RESOLVED → VERIFIED
These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Whoops. This was actually not backed out. Just mislabeled in the commit message.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Attachment #569152 - Flags: review?(sriram)
You need to log in before you can comment on or make changes to this bug.