Closed Bug 696850 Opened 9 years ago Closed 9 years ago

Support chrome:// and resource:// uris in favicons

Categories

(Firefox for Android :: General, defect)

x86
Android
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: fabrice, Assigned: fabrice)

Details

Attachments

(2 files)

Attached image about:home favicon
This is useful for chrome:// pages, and could also be used with the JS menu API.
Attached patch patchSplinter Review
Assignee: nobody → fabrice
Attachment #569160 - Flags: review?(mark.finkle)
Comment on attachment 569160 [details] [diff] [review]
patch


>+function resolveGeckoURI(aURI) {
>+  if (aURI.indexOf("chrome://") == 0) {
>+    let registry = Cc['@mozilla.org/chrome/chrome-registry;1'].getService(Ci["nsIChromeRegistry"]);
>+    return registry.convertChromeURL(Services.io.newURI(aURI, null, null)).spec;
>+  }
>+  else if (aURI.indexOf("resource://") == 0) {

} else if (...) {

r+
Attachment #569160 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/projects/birch/rev/04a7317963b9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Android; Linux armv7l rv:10.0a1) Gecko/20111025 Firefox/10.0a1 Fennec/10.0a1
Status: RESOLVED → VERIFIED
OS: Linux → Android
Hardware: x86_64 → x86
You need to log in before you can comment on or make changes to this bug.