696896 - Error sending to Valid email addresses

Status: RESOLVED FIXED

(Mozilla Labs :: F1, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

Try to share via gmail with an address of the form "Real Name <[e-mail]>" and you get:

info: SMTP OUT @ Tue Oct 25 2011 08:37:33 GMT+1100 (AUS Eastern Daylight Time):
RCPT TO: <Mark Hammond <[e-mail]>>

info: SMTP IN @ Tue Oct 25 2011 08:37:33 GMT+1100 (AUS Eastern Daylight Time):
555 5.5.2 Syntax error. 15sm66506991anz.16

info: EXCEPTION {"code":"error","message":"555 5.5.2 Syntax error. 15sm66506991anz.16"}
got gmail send result {"error":{"type":"server_error","reply":"555 5.5.2 Syntax error. 15sm66506991anz.16"}}
SEND FAILURE: error/555 5.5.2 Syntax error. 15sm66506991anz.16
error: mediator reported invocation error: There was a problem sharing this page: 555 5.5.2 Syntax error. 15sm66506991anz.16

Comment 1

[Mark Hammond [:markh] [:mhammond]]

The fix to this bug actually has 2 parts:

* Need an email address parser - not trivial but not rocket science either.

* The API needs to change - we will need to change resolveRecipients to parse the complete "to" line - currently the mediator does a simple split on a comma and passes the result array to resolveRecipients, but this will not handle email addresses of the form "Hammond, Mark <[e-mail]>".  Adding [api] so we can resolve this before evangelizing the api.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/35

Pointer to Github pull-request

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Fixed in commit 49d3d685ac002a8949b26efb3c0671e8368848ec