696900 - Reduce shutdown work in Places when possible

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

There are a couple cases we can optimize:

1. On shutdown of a clean database we expire session annotations.  This is conceptually correct, since they should disappear on shutdown, but why doing that even when there are no session annotations? Annotations service may know that, so just let it take care of the expiration when needed.

2. Win7 jumplists shutdown has to check if history has any entry, this is usually a quick path, since Places caches that value, but in some obvious cases the cache wrongly asks to be recalculated, rather than being set to a known value.  By setting the cache in more obvious cases we may avoid more updates, included the jumplists one on shutdown.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

I'm removing the analyze on shutdown test since it's bogus, it was actually measuring something we don't do anymore, likely fetching a timed expiration.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://tbpl.mozilla.org/?tree=Try&rev=6bbb6397af52

Clearly Ts shutdown got even worse...
Asking permission to land with all the patches and point people to bug 696053 for test improvements, I don't feel insane enough to fight windmills.

The only left work on Ts shutdown is finalizing some cached statements, this is the current situation:
http://tinyurl.com/5s43sdu

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 569230 [details] [diff] [review]
patch v1.0

Review of attachment 569230 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/nsAnnotationService.cpp
@@ +2022,5 @@
> +
> +NS_IMETHODIMP
> +nsAnnotationService::Observe(nsISupports *aSubject,
> +                        const char *aTopic,
> +                        const PRUnichar *aData)

nit: wonky indent

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e83437549628

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e83437549628