69691 - Installer should *not* leave the program folder open

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Henrik Gemal]

When doing the installation the installer leaves the "program folder" that 
you choose (normally mozilla) open.
This is not standard behavior on windows installer and is kind of wierd since 
the installer lauches mozilla at the end of the installation so there's no need 
to show the mozilla folder to the users.

Comment 1

[Matthew T (active 1999-2002)]

It's standard behavior on a lot of Windows installers I've seen. In fact, I 
think it would be preferable to open the folder rather than to launch Mozilla; 
if you're installing Mozilla on a bunch of PCs, you don't want to go around 
exiting Mozilla on all of them once you're done.

Comment 2

[timeless]

If I install mozilla on multiple pc's i'll use a script (do we have a command 
line parameter for silent installs?) or something, I don't want the folder to 
open up either -- especially because windows will remember that it opened the 
folder.

If an installer leaves a folder open, it's the start menu folder, not the 
installation folder.

Comment 3

[Henrik Gemal]

ups... wrong subject...:)

Comment 4

[Daniel Veditz [:dveditz]]

On windows there are lots of options, feed the "-h" option to it for a list. 
You can do a "silent" install, disable the launching at the end, disable the 
opening of the program group, etc.

Comment 5

[Henrik Gemal]

still think it should be the other way around. Default should be not to open the 
program folder. If the user then want to do it, he can do it via a "-opf" option

Comment 6

[timeless]

oh. also, please don't open an explorer window if explorer isn't running on the 
current deskbar.  especially if it's the shell.

Doing so results in a really ugly dialog box complaining about invalid 
parameters. but it does _not_ result in the folder being opened.

Steps to reproduce: run cmd.exe
click start>shutdown. hold ctrl-alt-**** click cancel/no.
enter the path to the installer, and go through the normal process.

fwiw this isn't actually the way i produced the behavior, i was using 
switcher.exe (requires NT, i use w2k) which meant that only some deskspaces had 
explorer running, and not the one where i was guinea pigging the 093 stub 
installer.

If you wnat a seperate bug for this i can file one.

Comment 7

[Sebastian Späth]

It does not open the Program folder of mozilla, but the start menu with the 3 
mozilla icons. It is not many installers doing so and it annoys me every time.

Mozilla is launched anyway (which is good to do all the initial registration at 
install time), presenting the icons is therefore somewhat unneccesary.

Comment 8

[Sean Su]

This should be an easy fix via the config.it file.  However, this is more like a
feature remove request.  I'll let Curt decide.  Perhaps we need UE input?

Comment 9

[Curt Patrick (gone)]

Gregg, could I get your on this bug?

Comment 10

[Curt Patrick (gone)]

Just to be perfectly clear, "input" is what I'd like to get.  Money is okay, too.

Comment 11

[s.marshall]

I just wanted to note that, though this was common behaviour in the days of
Windows 3.1 (with 'Program menu groups'), there is no real reason for it today
and the vast majority of modern installers do not open up start menu folders. It
shouldn't display at all, never mind staying open.

Users may likely not even expect to see bits of the start menu represented as a
folder in this way. It's not exactly the same way they will start the program in
future.

Basically, it's a very small thing and it only bugs me because I install the
program regularly :) but it does give a bad first impression, so would be nice
if it could be tweaked.

Comment 12

[Curt Patrick (gone)]

I'll go with s.marshall's input.  It makes sense to me.  And who wants to buck
"the vast majority of modern installers"!  Seriously, all I ever do is close
that folder and never open it again.  I can't think why anyone else would do
differently.

Comment 13

[Daniel Veditz [:dveditz]]

I think all you have to do is change the Show Folder= setting from SHOW to HIDE
in the installer config file.

Comment 14

[Sean Su]

oui

Comment 15

[Curt Patrick (gone)]

Attachment: One liner for mozilla

If your going to make it that easy for me I guess I should just fix it.  Here
is the patch.

Comment 16

[Curt Patrick (gone)]

Attachment: ditto for ns

Comment 17

[Curt Patrick (gone)]

The patches are checked in.  (Gregg, I sure hope we wanted this for NS, too,
cause I sure enough checked it in for both.)

Comment 18

[Curt Patrick (gone)]

BTW, I got r= and sr= verbally from Sean and Dan.

Comment 19

[Gregg Landskov (gone)]

Yes, that is fine.

Comment 20

[Henrik Gemal]

sure is fixed! hurray!