Closed Bug 696974 Opened 13 years ago Closed 11 years ago

Bookmarks engine: "invalid 'in' operand this._modified" in reconcile

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: rnewman, Assigned: rnewman)

Details

(Whiteboard: [qa-])

Attachments

(5 files)

1319265644827	Sync.Engine.Bookmarks	WARN	Encountered exception: invalid 'in' operand this._modified JS Stack trace: SyncEngine__reconcile([object Object])@engines.js:945 < ([object Object])@engines.js:765 < ()@record.js:828 < Channel_onDataAvail([object XPCWrappedNative_NoHelper],null,[object XPCWrappedNative_NoHelper],4129,786432)@resource.js:569

This is in Fx 7.0.1. Reported in Bug 693935.
Hi James, is this occurring on multiple machines, or only a specific one?  What Sync clients are you currently using?
Sorry Mike...I have not checked this thread since October and did not see an alert in my eMail.

One specific machine.
The only sync I use is the one built into Firefox 8.0.
Need more info?
The only way this can occur is if 

  loadChangedIDs: function T_loadChangedIDs() {
    Utils.jsonLoad("changes/" + this.file, this, function(json) {
      if (json) {
        this.changedIDs = json;
      }
    });
  },

screwed up. That is, if the changedIDs file contains a non-object value.

Otherwise, it's always an object.

So…
Hey look! A fix and a test!
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #694230 - Flags: review?(gps)
Comment on attachment 694230 [details] [diff] [review]
Proposed patch. v1

Review of attachment 694230 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/sync/tests/unit/test_engine.js
@@ +117,5 @@
> +  tracker.changedIDs = 5;
> +  tracker.saveChangedIDs(function onSaved() {
> +      tracker.changedIDs = {placeholder: true};
> +      tracker.loadChangedIDs(function onLoaded(json) {
> +        do_check_eq(null, json);

do_check_null(json);
Attachment #694230 - Flags: review?(gps) → review+
https://hg.mozilla.org/services/services-central/rev/b29575b9f9dd
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: [fixed in services][qa-]
https://hg.mozilla.org/mozilla-central/rev/b29575b9f9dd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → mozilla20
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: