Last Comment Bug 697013 - Change about window to be an accessible dialog and put all relevant static info into its acc description
: Change about window to be an accessible dialog and put all relevant static in...
Product: Thunderbird
Classification: Client Software
Component: Disability Access (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 10.0
Assigned To: Marco Zehe (:MarcoZ)
Depends on:
  Show dependency treegraph
Reported: 2011-10-24 22:18 PDT by James Teh [:Jamie]
Modified: 2011-11-14 06:28 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Patch (1.61 KB, patch)
2011-10-26 06:13 PDT, Marco Zehe (:MarcoZ)
bwinton: review+
Details | Diff | Splinter Review

Description User image James Teh [:Jamie] 2011-10-24 22:18:43 PDT
This will make the About dialog more accessible to screen reader users. It was done for Firefox in bug 694266. These changes should be ported to Thunderbird.
Comment 1 User image Marco Zehe (:MarcoZ) 2011-10-26 06:13:24 PDT
Created attachment 569656 [details] [diff] [review]

Tell screen readers that this is a dialog, and put all relevant descriptive text into the dialog accessible's description so screen readers read the info automatically.
Comment 2 User image Blake Winton (:bwinton) (:☕️) 2011-10-26 10:43:25 PDT
Comment on attachment 569656 [details] [diff] [review]

Review of attachment 569656 [details] [diff] [review]:

Okay, makes sense to me, I guess.

r=me with the question below answered (or the patch changed to match Firefox's).


::: mail/base/content/aboutDialog.xul
@@ +63,5 @@
>  #else
>          title="&aboutDialog.title;"
>  #endif
> +        role="dialog"
> +        aria-describedby="version distribution distributionId currentChannelText communityDesc contributeDesc"

So, why does Thunderbird get "currentChannelText", whereas Firefox gets "trademark"?
Comment 3 User image Marco Zehe (:MarcoZ) 2011-10-26 11:00:49 PDT
currentChannel is, if I didn't overlook it, not available in the Firefox version of the dialog.
trademark has been added locally. Thanks for the catch!
Comment 4 User image Marco Zehe (:MarcoZ) 2011-10-26 11:30:02 PDT

Note You need to log in before you can comment on or make changes to this bug.