Closed Bug 697076 Opened 10 years ago Closed 10 years ago
Fix Clang warnings
This patch fixes a bunch of warnings like these: 1) jsinfer.cpp:350:5: warning: indirection of non-volatile null pointer will be deleted, not trap [-Wnull-dereference] *((int*)NULL) = 0; /* Should never be reached */ ^~~~~~~~~~~~~ jsinfer.cpp:350:5: note: consider using __builtin_trap() or qualifying pointer with 'volatile' 2) An unused parameter in editline.c 3) jswrapper.cpp:880:16: warning: explicit instantiation of 'js::SecurityWrapper' must occur in namespace 'js' [-Wc++0x-compat] template class SecurityWrapper<Wrapper>; With this patch there are still many warnings caused by the JS_DEFINE_CALLINFO_* macros. The fix there is not obvious so I'll just ignore them until the tracer is gone.
Attachment #569344 - Flags: review?(luke)
The summury gived the impression of a meta-bug. Is it?
The summury gives the impression of a meta-bug. Is it?
Comment on attachment 569344 [details] [diff] [review] Patch Thanks
Attachment #569344 - Flags: review?(luke) → review+
Assignee: general → jandemooij
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla10
(In reply to David Bruant from comment #2) > The summury gives the impression of a meta-bug. Is it? No, it was not supposed to be a meta-bug :)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.