Last Comment Bug 697076 - Fix Clang warnings
: Fix Clang warnings
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86 Mac OS X
-- normal (vote)
: mozilla10
Assigned To: Jan de Mooij [:jandem]
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2011-10-25 06:35 PDT by Jan de Mooij [:jandem]
Modified: 2011-10-26 17:05 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (3.82 KB, patch)
2011-10-25 06:35 PDT, Jan de Mooij [:jandem]
luke: review+
Details | Diff | Splinter Review

Description User image Jan de Mooij [:jandem] 2011-10-25 06:35:46 PDT
Created attachment 569344 [details] [diff] [review]

This patch fixes a bunch of warnings like these:

1) jsinfer.cpp:350:5: warning: indirection of non-volatile null pointer will be deleted, not trap [-Wnull-dereference]
    *((int*)NULL) = 0;  /* Should never be reached */
jsinfer.cpp:350:5: note: consider using __builtin_trap() or qualifying pointer with 'volatile'

2) An unused parameter in editline.c

3) jswrapper.cpp:880:16: warning: explicit instantiation of 'js::SecurityWrapper' must occur in namespace 'js' [-Wc++0x-compat]
template class SecurityWrapper<Wrapper>;

With this patch there are still many warnings caused by the JS_DEFINE_CALLINFO_* macros. The fix there is not obvious so I'll just ignore them until the tracer is gone.
Comment 1 User image David Bruant 2011-10-25 07:40:26 PDT
The summury gived the impression of a meta-bug. Is it?
Comment 2 User image David Bruant 2011-10-25 07:40:54 PDT
The summury gives the impression of a meta-bug. Is it?
Comment 3 User image Luke Wagner [:luke] 2011-10-25 08:14:57 PDT
Comment on attachment 569344 [details] [diff] [review]

Comment 5 User image Jan de Mooij [:jandem] 2011-10-26 03:32:43 PDT
(In reply to David Bruant from comment #2)
> The summury gives the impression of a meta-bug. Is it?

No, it was not supposed to be a meta-bug :)
Comment 6 User image Ed Morley [:emorley] 2011-10-26 17:05:14 PDT

Note You need to log in before you can comment on or make changes to this bug.