The default bug view has changed. See this FAQ.

Remove nsIDocument::CreateElem's aDocumentDefaultType argument

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
Created attachment 569452 [details] [diff] [review]
Part a: Make GetDefaultNamespaceID return mDefaultElementType

As suggested by bz.
Attachment #569452 - Flags: review?(bzbarsky)
Flags: in-testsuite-
(Assignee)

Comment 1

6 years ago
Created attachment 569453 [details] [diff] [review]
Part b: Update nsDocument::CreateElement
Attachment #569453 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

6 years ago
Created attachment 569454 [details] [diff] [review]
Part c: Remove the argument
Attachment #569454 - Flags: review?(bzbarsky)
Comment on attachment 569452 [details] [diff] [review]
Part a: Make GetDefaultNamespaceID return mDefaultElementType

This seems fine, but you can also just move the member up to nsIDocument and make GetDefaultNamespaceID() non-virtual, right?
Attachment #569452 - Flags: review?(bzbarsky) → review+
Comment on attachment 569453 [details] [diff] [review]
Part b: Update nsDocument::CreateElement

r=me
Attachment #569453 - Flags: review?(bzbarsky) → review+
Comment on attachment 569454 [details] [diff] [review]
Part c: Remove the argument

r=me

Followup bug on removing the aElementType argument of NS_NewElement?
Attachment #569454 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

6 years ago
(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 569452 [details] [diff] [review] [diff] [details] [review]
> Part a: Make GetDefaultNamespaceID return mDefaultElementType
> 
> This seems fine, but you can also just move the member up to nsIDocument and
> make GetDefaultNamespaceID() non-virtual, right?

Done.

https://hg.mozilla.org/mozilla-central/rev/8698204c6707
https://hg.mozilla.org/mozilla-central/rev/c8234c84bf9d
https://hg.mozilla.org/mozilla-central/rev/82469275d2fe
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Depends on: 698261
You need to log in before you can comment on or make changes to this bug.