Closed
Bug 697210
Opened 13 years ago
Closed 13 years ago
Remove nsIDocument::CreateElem's aDocumentDefaultType argument
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(3 files)
|
2.48 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
894 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
11.70 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
As suggested by bz.
Attachment #569452 -
Flags: review?(bzbarsky)
Flags: in-testsuite-
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #569453 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #569454 -
Flags: review?(bzbarsky)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 569452 [details] [diff] [review]
Part a: Make GetDefaultNamespaceID return mDefaultElementType
This seems fine, but you can also just move the member up to nsIDocument and make GetDefaultNamespaceID() non-virtual, right?
Attachment #569452 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 569453 [details] [diff] [review]
Part b: Update nsDocument::CreateElement
r=me
Attachment #569453 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 569454 [details] [diff] [review]
Part c: Remove the argument
r=me
Followup bug on removing the aElementType argument of NS_NewElement?
Attachment #569454 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 569452 [details] [diff] [review] [diff] [details] [review]
> Part a: Make GetDefaultNamespaceID return mDefaultElementType
>
> This seems fine, but you can also just move the member up to nsIDocument and
> make GetDefaultNamespaceID() non-virtual, right?
Done.
https://hg.mozilla.org/mozilla-central/rev/8698204c6707
https://hg.mozilla.org/mozilla-central/rev/c8234c84bf9d
https://hg.mozilla.org/mozilla-central/rev/82469275d2fe
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•