Last Comment Bug 697210 - Remove nsIDocument::CreateElem's aDocumentDefaultType argument
: Remove nsIDocument::CreateElem's aDocumentDefaultType argument
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on: 698261
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-25 12:05 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-10-30 05:40 PDT (History)
2 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part a: Make GetDefaultNamespaceID return mDefaultElementType (2.48 KB, patch)
2011-10-25 12:05 PDT, :Ms2ger (⌚ UTC+1/+2)
bzbarsky: review+
Details | Diff | Splinter Review
Part b: Update nsDocument::CreateElement (894 bytes, patch)
2011-10-25 12:05 PDT, :Ms2ger (⌚ UTC+1/+2)
bzbarsky: review+
Details | Diff | Splinter Review
Part c: Remove the argument (11.70 KB, patch)
2011-10-25 12:06 PDT, :Ms2ger (⌚ UTC+1/+2)
bzbarsky: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-10-25 12:05:07 PDT
Created attachment 569452 [details] [diff] [review]
Part a: Make GetDefaultNamespaceID return mDefaultElementType

As suggested by bz.
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2011-10-25 12:05:42 PDT
Created attachment 569453 [details] [diff] [review]
Part b: Update nsDocument::CreateElement
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-10-25 12:06:18 PDT
Created attachment 569454 [details] [diff] [review]
Part c: Remove the argument
Comment 3 Boris Zbarsky [:bz] (TPAC) 2011-10-25 12:24:16 PDT
Comment on attachment 569452 [details] [diff] [review]
Part a: Make GetDefaultNamespaceID return mDefaultElementType

This seems fine, but you can also just move the member up to nsIDocument and make GetDefaultNamespaceID() non-virtual, right?
Comment 4 Boris Zbarsky [:bz] (TPAC) 2011-10-25 12:26:36 PDT
Comment on attachment 569453 [details] [diff] [review]
Part b: Update nsDocument::CreateElement

r=me
Comment 5 Boris Zbarsky [:bz] (TPAC) 2011-10-25 12:27:36 PDT
Comment on attachment 569454 [details] [diff] [review]
Part c: Remove the argument

r=me

Followup bug on removing the aElementType argument of NS_NewElement?
Comment 6 :Ms2ger (⌚ UTC+1/+2) 2011-10-30 05:33:00 PDT
(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 569452 [details] [diff] [review] [diff] [details] [review]
> Part a: Make GetDefaultNamespaceID return mDefaultElementType
> 
> This seems fine, but you can also just move the member up to nsIDocument and
> make GetDefaultNamespaceID() non-virtual, right?

Done.

https://hg.mozilla.org/mozilla-central/rev/8698204c6707
https://hg.mozilla.org/mozilla-central/rev/c8234c84bf9d
https://hg.mozilla.org/mozilla-central/rev/82469275d2fe

Note You need to log in before you can comment on or make changes to this bug.