697304 - Remove sql from common_model in webapp

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Lonnen :lonnen]

webapp-php/application/models/common.php contains quite a bit of sql interacting with the reports table. Lets get that moved into the services layer.

The model could potentially be refactored to be report_model, since its functionality is not really common. It's used in three files, really two, and could be cleaned up a bit.

* controllers/feed.php
    instantiates it directly to call `queryReports` twice.
* libraries/MY_Controller.php
    instantiates it to store it as a var
* controllers/report.php
    uses the MY_Controller local instance to call every method but `queryTopSignatures`, which is dead code.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/e0c8e7e7bb644e5d36aba9ab2cc4b1f5718f72e0
Fixes bug 697304 - Removed the obsolete common model.

https://github.com/mozilla/socorro/commit/244dca541bc8548a2d71c654ed9e38d74fd52d6c
Merge pull request #504 from AdrianGaudebert/697304-remove-common-model

Fixes bug 697304 - Removed the obsolete common model.

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Steps to QA
-----------

1. Verify nothing is broken. 
2. Enjoy the rest of your day.

Comment 3

[Matt Brandt [:mbrandt]]

Thanks adrian, QA verified on stage - automation run and passes.