69737 - Win95 (actually Win ME) build fails in embedding

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Syd Logan]

The problem seems to be we are calling regsvr32 to register DLLs from within 
makefiles. Perhaps the args to this command are wrong, and we need to ifdef 
win95 or something around the correct version in the makefile. However, I wonder 
if we should even be doing this in the makefile, seems like something a test app 
or batch file should do, not the make system.

I'll apply a patch (I just removed the calls, there is a better solution) so you 
can see what files are effected.

Comment 1

[Syd Logan]

Attachment: files that have "the problem"

Comment 2

[Adam Lock]

I think 95/98/Me may call their version just "regsvr" rather than "regsvr32". 
Can you verify since I don't have a box to check?

If so then we could use a macro instead called REGSVR which is conditionally set 
it to one or the other.

Comment 3

[Syd Logan]

Attachment: Patch to fix the problem

Comment 4

[Syd Logan]

Attachment: ignore the previous one, had it flipped.

Comment 5

[Adam Lock]

This looks good, r=adamlock. Do you want to check this in or shall I?

Comment 6

[Syd Logan]

I deleted winme in disgust in favor of Windows NT, so if you could apply the 
patch and check it once again, that'd be great.

Comment 7

[Adam Lock]

Fix is checked in. Thanks Syd.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

*** Bug 45546 has been marked as a duplicate of this bug. ***