697379 - Fix the buildsymbols target for lightning on Windows

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Running:

make -C objdir/calendar/lightning buildsymbols

on windows currently fails.

If this can be fixed and buildbot updated to run buildsymbols from that directory, then it'll save about 10 minutes per build.

Comment 1

[Mark Banner (:standard8)]

Slightly more detailed log from bug 673083 comment 9:

rm -f -r ../../mozilla/dist/crashreporter-symbols
rm -f "../../mozilla/dist/thunderbird-9.0a1.en-US.win32.crashreporter-symbols.zip"
e:/buildbot/comm-central-win32-nightly/build/objdir-tb/mozilla/config/nsinstall.exe -D ../../mozilla/dist/crashreporter-symbols
d:/mozilla-build/python25/python2.5.exe /e/buildbot/comm-central-win32-nightly/build/mozilla/toolkit/crashreporter/tools/symbolstore.py \
	  -c --vcs-info                                          \
	  -s /e/buildbot/comm-central-win32-nightly/build               \
	  /e/buildbot/comm-central-win32-nightly/build/toolkit/crashreporter/tools/win32/dump_syms_vc1400.exe                                                \
	  ../../mozilla/dist/crashreporter-symbols                                   \
	  . >                                        \
	  ../../mozilla/dist/crashreporter-symbols/thunderbird-9.0a1-WINNT-20110912041544-symbols.txt
echo packing symbols
packing symbols
e:/buildbot/comm-central-win32-nightly/build/objdir-tb/mozilla/config/nsinstall.exe -D ../../mozilla/dist/
cd ../../mozilla/dist/crashreporter-symbols && \
          zip -r9D "../thunderbird-9.0a1.en-US.win32.crashreporter-symbols-full.zip" .
  adding: thunderbird-9.0a1-WINNT-20110912041544-symbols.txt (164 bytes security) (stored 0%)
cd ../../mozilla/dist/crashreporter-symbols && \
	grep "sym" thunderbird-9.0a1-WINNT-20110912041544-symbols.txt > thunderbird-9.0a1-WINNT-20110912041544-symbols.txt.tmp && \
	  mv thunderbird-9.0a1-WINNT-20110912041544-symbols.txt.tmp thunderbird-9.0a1-WINNT-20110912041544-symbols.txt
make: *** [buildsymbols] Error 1

I suspect this just needs the correct symbol path for windows figuring out - I'll have to look at that later.

Comment 2

[Edmund Wong (:ewong)]

Attachment: Fixed the buildsymbols target. (v1)

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 580747 [details] [diff] [review]
Fixed the buildsymbols target. (v1)

Looks good to me. Please push to comm-central,comm-aurora and comm-beta!

Comment 4

[Edmund Wong (:ewong)]

Comment on attachment 580747 [details] [diff] [review]
Fixed the buildsymbols target. (v1)

Please treat this as an approval-comm-aurora? and approval-comm-beta?
(Neither flags exist right now)

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 580747 [details] [diff] [review]
Fixed the buildsymbols target. (v1)

O I missed the fact that Fallen said to push to aurora/beta when I advised you on IRC for this, go ahead and push there :-)

Comment 6

[Edmund Wong (:ewong)]

Pushed to comm-central : http://hg.mozilla.org/comm-central/rev/e490369977e6
Pushed to comm-aurora  : http://hg.mozilla.org/releases/comm-aurora/rev/85f02f719a96
Pushed to comm-beta    : http://hg.mozilla.org/releases/comm-beta/rev/cb9da6cae728

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 580747 [details] [diff] [review]
Fixed the buildsymbols target. (v1)

 	cd $(DIST)/crashreporter-symbols && \
-	grep "sym" $(SYMBOL_INDEX_NAME) > $(SYMBOL_INDEX_NAME).tmp && \
+	  grep "sym" $(SYMBOL_INDEX_NAME) > $(SYMBOL_INDEX_NAME).tmp
 	  mv $(SYMBOL_INDEX_NAME).tmp $(SYMBOL_INDEX_NAME)

This change breaks buildsymbols. The move command must follow-on from the previous lines as otherwise you're no longer in the right directory.

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

Oops, missed that one. I thought it was only the whitespace change. Edmund, could you push a fix for this? (r=philipp)

Comment 9

[Stefan Sitter [:ssitter]]

Nightly builds are broken on all platforms. Please backout the patch or push a fix.

Comment 10

[Edmund Wong (:ewong)]

Attachment: Fixed patch for previous patch's error.

Comment 11

[Edmund Wong (:ewong)]

Pushed to comm-central: 
http://hg.mozilla.org/comm-central/rev/823216c45b77

Comment 12

[Edmund Wong (:ewong)]

(In reply to Edmund Wong from comment #11)
> Pushed to comm-central: 
> http://hg.mozilla.org/comm-central/rev/823216c45b77

I don't have comm-beta and comm-aurora on this machine and need to clone.  
Will push to them when I have them cloned.

Comment 13

[Edmund Wong (:ewong)]

Pushed to Comm-Aurora:
 http://hg.mozilla.org/releases/comm-aurora/rev/0c2f7e874143

Pushed to Comm-Beta:
 http://hg.mozilla.org/releases/comm-beta/rev/11e5558d027c