697445 - Preview doesn't work on article discussions

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Verdi [:verdi] Best to slack me]

When I preview my post on an article's discussion tab discussion I get an error that says, "There was an error generating the preview."

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Related:

Traceback (most recent call last):

  File "/data/www/support.mozilla.com/kitsune/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/support.mozilla.com/kitsune/vendor/src/django/django/views/decorators/http.py", line 45, in inner
    return func(request, *args, **kwargs)

  File "/data/www/support.mozilla.com/kitsune/apps/access/decorators.py", line 47, in _wrapped_view
    return view_fn(request, *args, **kwargs)

  File "/data/www/support.mozilla.com/kitsune/apps/kbforums/views.py", line 387, in post_preview_async
    {'post_preview': post})

  File "/data/www/support.mozilla.com/kitsune/vendor/src/jingo/jingo/__init__.py", line 76, in render
    rendered = render_to_string(request, template, context)

  File "/data/www/support.mozilla.com/kitsune/vendor/src/jingo/jingo/__init__.py", line 94, in render_to_string
    return template.render(**get_context())

  File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/www/support.mozilla.com/kitsune/apps/kbforums/templates/kbforums/includes/post_preview.html", line 6, in top-level template code
    {% include "kbforums/includes/post.html" %}

  File "/data/www/support.mozilla.com/kitsune/apps/kbforums/templates/kbforums/includes/post.html", line 20, in top-level template code
    {% if document.slug and post.id %}

  File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 371, in getattr
    return getattr(obj, attribute)

UndefinedError: 'document' is undefined

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

next: https://github.com/jsocol/kitsune/commit/19281d58e0a3e116c2c3bafbe4907e7c4d21001c

master: https://github.com/jsocol/kitsune/commit/b22ce72c323ae433beccd0aab877c6c0dae93b6c

Comment 3

[Rebecca Billings [:rbillings]]

Verified previews do not generate an error.