deCOMtaminate nsSVGPatternFrame::GetPatternFirstChild

RESOLVED FIXED in mozilla10

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
This MXR search...
http://mxr.mozilla.org/mozilla-central/search?string=PatternFirstChild
...shows that GetPatternFirstChild() is only mentioned inside of nsSVGPatternFrame.[h,cpp]

This currently has NS_IMETHOD / NS_IMETHODIMP annotations, but these aren't necessary, because the method isn't declared in an IDL file.

This method can just return nsresult.

BTW, hg/cvs archeology shows that the line of code with this method's declaration hasn't changed since the original revision of the file, from bug 336653 ("Remove nsISVGPattern").  So, presumably this is just left over from when we had an XPCOM nsISVGPattern interface.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/svg/base/src/nsSVGPatternFrame.h#135
(Assignee)

Comment 1

6 years ago
Actually, this method can just directly return a nsIFrame*.
Assignee: nobody → dholbert
OS: Linux → All
Hardware: x86 → All
(Assignee)

Updated

6 years ago
Summary: nsSVGPatternFrame::GetPatternFirstChild has unnecessary NS_IMETHOD → de-COM nsSVGPatternFrame::GetPatternFirstChild
(Assignee)

Updated

6 years ago
Blocks: 105431
Depends on: 336653
Summary: de-COM nsSVGPatternFrame::GetPatternFirstChild → deCOMtaminate nsSVGPatternFrame::GetPatternFirstChild
(Assignee)

Comment 2

6 years ago
Created attachment 569730 [details] [diff] [review]
fix
Attachment #569730 - Flags: review?(longsonr)

Updated

6 years ago
Attachment #569730 - Flags: review?(longsonr) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b317557f9b78
Whiteboard: [inbound]
Target Milestone: --- → mozilla10

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/b317557f9b78
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.