Closed Bug 697475 Opened 12 years ago Closed 12 years ago

deCOMtaminate nsSVGPatternFrame::GetPatternFirstChild

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

fix
3.43 KB, patch
longsonr
: review+
Details | Diff | Splinter Review 
This MXR search...
http://mxr.mozilla.org/mozilla-central/search?string=PatternFirstChild
...shows that GetPatternFirstChild() is only mentioned inside of nsSVGPatternFrame.[h,cpp]

This currently has NS_IMETHOD / NS_IMETHODIMP annotations, but these aren't necessary, because the method isn't declared in an IDL file.

This method can just return nsresult.

BTW, hg/cvs archeology shows that the line of code with this method's declaration hasn't changed since the original revision of the file, from bug 336653 ("Remove nsISVGPattern").  So, presumably this is just left over from when we had an XPCOM nsISVGPattern interface.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/svg/base/src/nsSVGPatternFrame.h#135
Actually, this method can just directly return a nsIFrame*.
Assignee: nobody → dholbert
OS: Linux → All
Hardware: x86 → All
Summary: nsSVGPatternFrame::GetPatternFirstChild has unnecessary NS_IMETHOD → de-COM nsSVGPatternFrame::GetPatternFirstChild
Blocks: deCOM
Depends on: 336653
Summary: de-COM nsSVGPatternFrame::GetPatternFirstChild → deCOMtaminate nsSVGPatternFrame::GetPatternFirstChild
Attached patch fix — — Splinter Review 

        Attachment #569730 -
        Flags: review?(longsonr)

        Attachment #569730 -
        Flags: review?(longsonr) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/b317557f9b78
Whiteboard: [inbound]
Target Milestone: --- → mozilla10

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b317557f9b78
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.