697476 - Remove Karen from config.php

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Peter Bengtsson [:peterbe]]

On the old PTO app, it's configured to send notifications to Karen. The file config.php isn't part of the SVN so it needs to be edited manually on the server.

Where the PTO trunk is checked out, there'll be a file called config.php and it'll contain something like this:

 $hr_managers = array(
   "[e-mail]",
   "[e-mail]"
 );

We need to remove Karen from that array.

Comment 1

[Fred Wenzel [:wenzel]]

If Dan Portillo is in there, he needs to be removed as well ;)

Comment 2

[Justin Dow [:jabba]]

Done!

on irc, we decided to just remove her from the notified_people array, so we are now left with this:

# Specify HR managers with email addresses only.
$hr_managers = array(
  "[e-mail]",
  "[e-mail]"
);

# Specified in RFC address format. One address per array element, please.
$notified_people = array(
  "Jill Van De Ven <[e-mail]>"
);

Comment 3

[Peter Bengtsson [:peterbe]]

Apparently, this didn't work. Karen is still getting notifications. I doubt it's related to caching. More likely, does the PHP code need apache to gracefully restart or something?

Secondly, removing Karen was apparently not good enough. I've talk to Jill and apparently the definitive correct list is this::

 [e-mail]
 [e-mail]

Today I re-wrote the pending new PTO app a bit so that this list of notifiers isn't a hardcoded setting anymore. It's instead a piece of profile data in the database which can be edited from the Django admin interface.

Comment 4

[Justin Dow [:jabba]]

It looks like this now:

# Specify HR managers with email addresses only.
$hr_managers = array(
  "[e-mail]",
  "[e-mail]",
  "[e-mail]"
);

# Specified in RFC address format. One address per array element, please.
$notified_people = array(
  "Jill Van De Ven <[e-mail]>"
  "Doris Coleman <[e-mail]>"
);

Comment 5

[Peter Bengtsson [:peterbe]]

Unfortunately I have no way of testing this other than hearing from Jill and Karen if the notification was still sent incorrectly. Did you do any restarting of Apache or something like to make it take effect?

Comment 6

[jill]

for the $hr_manager = array can we please remove [e-mail]?

Comment 7

[Justin Dow [:jabba]]

I removed jcook.

PHP apps don't require an apache restart to take effect, so we should be good to go on this.

Comment 8

[Peter Bengtsson [:peterbe]]

Jill, keep an eye on the notifications going out to see if it's routed correctly and let us know.