Closed Bug 69762 Opened 24 years ago Closed 23 years ago

nsImageFrame.cpp#344 seems to incorrectly scope a variable

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED DUPLICATE of bug 70989

People

(Reporter: timeless, Assigned: timeless)

References

(
URL
)

Details

if (mLowSrcImageLoader != nsnull && !(mImageLoader.GetLoadStatus() & 
NS_IMAGE_LOAD_STATUS_IMAGE_READY)) {
    PRBool gotDesiredSize = mLowSrcImageLoader->GetDesiredSize(aPresContext, 
&aReflowState, aDesiredSize);
    /*if (gotDesiredSize) {
      // We have our "final" desired size. Cancel any pending
      // incremental reflows aimed at this frame.
      nsIPresShell* shell;
      aPresContext->GetShell(&shell);
      if (shell) {
        shell->CancelReflowCommand(this, nsnull);
        NS_RELEASE(shell);
      }
    }*/
  }

rods: do you intend to uncomment that code? if not, could i delete 
the /*..block..*/ and remove |PRBool gotDesiredSize = | ?
Correcting summary.
Summary: nsURILoader.cpp#382 seems to incorrectly scope a variable → nsImageFrame.cpp#344 seems to incorrectly scope a variable
timeless, Are you going to look at this. If so, please give it a milestone. If 
not, please reassign to attinasi.
Seems to me I already reviewed changes to this in bug 70989...

*** This bug has been marked as a duplicate of 70989 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.