The default bug view has changed. See this FAQ.

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: aaronmt, Assigned: sriram)

Tracking

({uiwanted})

unspecified
ARM
Android
uiwanted
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

(Whiteboard: [parity-all])

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Re-add the the ability to stop page load.

Comment 1

6 years ago
not in the design spec.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
Assignee: nobody → madhava
Status: RESOLVED → REOPENED
Keywords: uiwanted
Priority: -- → P1
Resolution: INVALID → ---
Whiteboard: [party-all] → [parity-all]
don't listen to dougt
Status: REOPENED → NEW
Sorry, who?

When a page is loading, let's have a button at the end of the titlebar (i.e. where we put it in previous versions). The difference is that we won't replace it with refresh in the new one. When you need stop, it's pretty useful to have to have it available immediately.
(In reply to Madhava Enros [:madhava] from comment #3)
> The difference is that we won't
> replace it with refresh in the new one. 

why not?
(In reply to Brad Lassey [:blassey] from comment #4)
> (In reply to Madhava Enros [:madhava] from comment #3)
> > The difference is that we won't
> > replace it with refresh in the new one. 
> 
> why not?

or more specifically, what do you want to do here? have it go away when the page finishes loading? or just have a disabled stop button when the page finishes loading? If its the latter, I think it would be better for it to turn into a refresh button. For the former I wonder how that transition will look.
Created attachment 571325 [details]
URL bar states

Hi everyone, here's a mock of all the various URL bar states that should clarify some of these interaction questions. 

With regard to the Stop button, it only appears when the page is loading, and then goes away once loading has finished.
Created attachment 571326 [details]
Graphic assets for header icons

Includes Stop, Lock, and Go icons, prepared for Gingerbread and ICS
Assignee: madhava → nobody
Assignee: nobody → sriram
(Assignee)

Comment 8

5 years ago
Created attachment 575029 [details] [diff] [review]
Patch

This patch adds the stop functionality.

I am not sure if I should send the event directly from BrowserToolbar. I tried to be consistent in call GeckoApp from BrowserToolbar, which inturn calls Tab's stop().

We need high resolution assets for stop button.
Attachment #575029 - Flags: review?(mark.finkle)
(Assignee)

Updated

5 years ago
Blocks: 703115
Attachment #575029 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/projects/birch/rev/14e6f9bd949d
Status: NEW → RESOLVED
Last Resolved: 6 years ago5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

5 years ago
Samsung Nexus S (Android 2.3.6)
20111118040220
http://hg.mozilla.org/projects/birch/rev/9999a423d8ab
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.