Closed Bug 697726 Opened 8 years ago Closed 8 years ago
Re-add the the ability to stop page load.
not in the design spec.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Assignee: nobody → madhava
Status: RESOLVED → REOPENED
Priority: -- → P1
Resolution: INVALID → ---
Whiteboard: [party-all] → [parity-all]
don't listen to dougt
Status: REOPENED → NEW
Sorry, who? When a page is loading, let's have a button at the end of the titlebar (i.e. where we put it in previous versions). The difference is that we won't replace it with refresh in the new one. When you need stop, it's pretty useful to have to have it available immediately.
(In reply to Madhava Enros [:madhava] from comment #3) > The difference is that we won't > replace it with refresh in the new one. why not?
(In reply to Brad Lassey [:blassey] from comment #4) > (In reply to Madhava Enros [:madhava] from comment #3) > > The difference is that we won't > > replace it with refresh in the new one. > > why not? or more specifically, what do you want to do here? have it go away when the page finishes loading? or just have a disabled stop button when the page finishes loading? If its the latter, I think it would be better for it to turn into a refresh button. For the former I wonder how that transition will look.
Hi everyone, here's a mock of all the various URL bar states that should clarify some of these interaction questions. With regard to the Stop button, it only appears when the page is loading, and then goes away once loading has finished.
Includes Stop, Lock, and Go icons, prepared for Gingerbread and ICS
This patch adds the stop functionality. I am not sure if I should send the event directly from BrowserToolbar. I tried to be consistent in call GeckoApp from BrowserToolbar, which inturn calls Tab's stop(). We need high resolution assets for stop button.
Attachment #575029 - Flags: review?(mark.finkle)
Attachment #575029 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Samsung Nexus S (Android 2.3.6) 20111118040220 http://hg.mozilla.org/projects/birch/rev/9999a423d8ab
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.