697818 - new loader does not notifies cfx when browser is closed

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Comment 1

[Brian Warner [:warner :bwarner]]

'cfx' is waiting to see an "OK" or "FAIL" in the resultsFile, which is only written to by require("system").exit(). The old loader (probably in the bootstrap.js) must have had some sort of on-exit hook to emit the result string.

Indeed, the old components/harness.js used to include an "onQuit" property in the "Harness Service XPCOM Component" it created, which wrote to the resultsFile, and other exit functions passed through onQuit: https://github.com/mozilla/addon-sdk/blob/c2216d99934f89a4e31e5b857252a08ccc28e882/python-lib/cuddlefish/app-extension/components/harness.js#L427

I don't think we're using a harness service anymore. Is there some other on-exit hook we could use?

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/252

Pointer to Github pull-request

Comment 3

[Brian Warner [:warner :bwarner]]

Comment on attachment 570218 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/252

ok, that branch as of https://github.com/Gozala/addon-sdk/commit/303029030b9601df5a35867991f7cb0c3325c161 looks good to me

Comment 4

[Brian Warner [:warner :bwarner]]

I landed this in https://github.com/mozilla/addon-sdk/commit/64ce13b1042f7caa9d3f529f41c47b5c928b6e2b , forgot to close this bug.