Last Comment Bug 697845 - only call glFinish in RenderLayer, not in UpdateSurface
: only call glFinish in RenderLayer, not in UpdateSurface
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla10
Assigned To: Benoit Jacob [:bjacob] (mostly away)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks: 708125 711649
  Show dependency treegraph
 
Reported: 2011-10-27 14:51 PDT by Benoit Jacob [:bjacob] (mostly away)
Modified: 2011-12-16 15:40 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
move glFinish to RenderLayer (1.43 KB, patch)
2011-10-27 14:51 PDT, Benoit Jacob [:bjacob] (mostly away)
matt.woodrow: review+
Details | Diff | Splinter Review

Description Benoit Jacob [:bjacob] (mostly away) 2011-10-27 14:51:57 PDT
Created attachment 570097 [details] [diff] [review]
move glFinish to RenderLayer

Should be faster.
Comment 1 Benoit Jacob [:bjacob] (mostly away) 2011-10-29 16:16:55 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/eaaab958a659
Comment 2 Ed Morley [:emorley] 2011-10-30 10:34:33 PDT
https://hg.mozilla.org/mozilla-central/rev/eaaab958a659

Please can you use the "set assignee" feature when attaching patches, to save time on merging. Thanks!
Comment 3 Jeff Gilbert [:jgilbert] 2011-12-06 16:21:41 PST
Why did we move UpdateSurface-type code into the RenderLayer function? Why not just remove the unneeded glFlush in RenderLayer?

Note You need to log in before you can comment on or make changes to this bug.