generation of builtin code should take a switch to compile with and without float

VERIFIED FIXED

Status

Tamarin
Tools
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Brent Baker, Assigned: Virgil Palanciuc)

Tracking

(Blocks: 1 bug)

unspecified
Bug Flags:
in-testsuite -
flashplayer-qrb +
flashplayer-bug -
flashplayer-triage +

Details

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Right now you need to modify core/buitin.py in order to disable the generation of float builtin code. Should have the ability to pass a switch to turn this on and off.


./builtin.py --float=true|false [default=true?]
Flags: flashplayer-triage+
Flags: flashplayer-qrb+
Flags: flashplayer-bug-
(Reporter)

Comment 1

7 years ago
Created attachment 570255 [details] [diff] [review]
Nativegen tweak

emit the friend class for FloatVectorClass in a FLOAT_ONLY macro
Attachment #570255 - Flags: review?(virgilp)
(Reporter)

Updated

7 years ago
Assignee: nobody → virgilp
Flags: in-testsuite-
QA Contact: tools → brbaker
(Reporter)

Updated

7 years ago
Summary: compilation of builtin code should take a switch to compile with and without float → generation of builtin code should take a switch to compile with and without float
(Assignee)

Comment 2

7 years ago
Comment on attachment 570255 [details] [diff] [review]
Nativegen tweak

Checked, works ok.
Attachment #570255 - Flags: review?(virgilp) → review+
(Assignee)

Comment 3

7 years ago
still needs to be modified to take a parameter (VMCFG_FLOAT=true/false). Or is it better to use an environment variable for VMCFG_FLOAT? (e.g set the default to "false", override it with environment var).
(Reporter)

Comment 4

7 years ago
Nativegen Tweak patch pushed as 320:b31c31f05a17
(Reporter)

Comment 5

7 years ago
Created attachment 570558 [details] [diff] [review]
builtin.py tweak for FLOAT

default to NOT build the builtins with float enabled, to enable float set VMCFG_FLOAT=true in the env prior to running the script:

VMCFG_FLOAT=true ./builtin.py
Attachment #570558 - Flags: review?(virgilp)
(Assignee)

Comment 6

7 years ago
Comment on attachment 570558 [details] [diff] [review]
builtin.py tweak for FLOAT

It's ok, if we postulate that using environment variables for configuration is a good solution (I don't feel qualified to make that decision for the build environment).
Attachment #570558 - Flags: review?(virgilp) → review+
(Assignee)

Comment 7

7 years ago
FWIW - the build script changed, now it passes the parameters to ASC. This means that now to compile with float enabled, one should do:
 "cd core; ./builtin.py -abcfuture -config CONFIG::VMCFG_FLOAT=true Float.as"
while, in order to compile with float disabled, one should do:
 "cd core; ./builtin.py -config CONFIG::VMCFG_FLOAT=false"

It's a bit convoluted, but it helps us two areas:
1. We can pass arguments from ./configure.py (it's a bit harder to work with environment variables)
2. We can disable float& float4 classes, AND have new syntax used in Float.as (there is currently no way to convince ASC to ignore the Float.as file when VMCFG_FLOAT is false, other than not including it at all).
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

7 years ago
Added a message to configure.py to inform user how to call the script if no args are passed in:
changeset 6851:504afa69dd54
(Reporter)

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.