Closed Bug 698010 Opened 8 years ago Closed 8 years ago

devicemanagerADB's killProcess function doesn't actually work

Categories

(Testing :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla11

People

(Reporter: wlach, Assigned: wlach)

Details

Attachments

(2 files, 1 obsolete file)

devicemanagerADB's killProcess function could never work for the following reasons:

1. It calls ps on the process that it's trying to kill
2. It returns after only one iteration of the loop

It turns out that this method would be useful for the remote mozrunner class that I'm using, so I'm going to do up a patch to actually make this work.
Hey Joel, what do you think of this? I've tested this in isolation, but not yet in conjunction with anything else (I can't seem to get mochitest working with devicemanagerADB). If it looks good to you I'll generate a patch for talos as well.
Assignee: nobody → wlachance
Attachment #570305 - Flags: review?(jmaher)
Comment on attachment 570305 [details] [diff] [review]
Make killProcess method work in devicemanagerADB.py

Review of attachment 570305 [details] [diff] [review]:
-----------------------------------------------------------------

this is great, should we do this with other functions as well?
Attachment #570305 - Flags: review?(jmaher) → review+
If you mean "make them work", then yes, we should probably do that with other functions at some point. :) If you're referring to the runCmdAs thing I added, I don't see any other places in devicemanagerADB.py that would benefit from using it, but let me know if you do.
Eugh, this is embarassing. It turns out that the previous patch doesn't actually work. This one should. Could you re-review? Sorry for the bother.
Attachment #570305 - Attachment is obsolete: true
Attachment #570740 - Flags: review?(jmaher)
Comment on attachment 570740 [details] [diff] [review]
Make killProcess method work in devicemanagerADB.py take 2

Review of attachment 570740 [details] [diff] [review]:
-----------------------------------------------------------------

this looks fine.
Attachment #570740 - Flags: review?(jmaher) → review+
Hey Joel, could you commit these for me since you've reviewed them? :)
https://hg.mozilla.org/mozilla-central/rev/8c02d009d98e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.