Please add the closed tree check-in hook for birch

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: coop, Assigned: bkero)

Tracking

Details

Attachments

(1 attachment)

blassey would like the closed tree hook enabled on the birch project branch in hg, please.
Assignee: server-ops-releng → server-ops
Component: Server Operations: RelEng → Server Operations
QA Contact: zandr → cshields
(Reporter)

Comment 2

7 years ago
Created attachment 570327 [details] [diff] [review]
Adds birch to list of branches enforcing the tree closure hook
Attachment #570327 - Flags: review?(nrthomas)
Comment on attachment 570327 [details] [diff] [review]
Adds birch to list of branches enforcing the tree closure hook

<ted impression> r+ </ted>
Attachment #570327 - Flags: review?(nrthomas) → review+
Assignee: server-ops → bkero
Severity: major → normal
(Assignee)

Comment 4

7 years ago
Will somebody please apply this patch to the 'hghooks' repository and push their change, so we have a current copy of the hook in the repos, as well sa in production?
(Reporter)

Comment 5

7 years ago
Comment on attachment 570327 [details] [diff] [review]
Adds birch to list of branches enforcing the tree closure hook

Checked in:

https://hg.mozilla.org/hgcustom/hghooks/rev/453947e9e9de
(Assignee)

Comment 6

7 years ago
I've added the updated hook, please let me know if you run into any issues.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
This doesn't seem to be working; for example http://tinderbox.mozilla.org/Birch/status.html has <span id="treestatus" style="color: red;">CLOSED</span> right now, but it did not stop pushes from succeeding.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

7 years ago
I've found the issue was that the hooks were not correctly placed in the repository's hgrc file, only that the hook was updated to allow for the birch repository to be closed.

Please try again, I've enabled the hooks for the repository.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
Product: mozilla.org → mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.