698033 - Please add the closed tree check-in hook for birch

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Chris Cooper [:coop] (he/him)]

blassey would like the closed tree hook enabled on the birch project branch in hg, please.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

coop, http://hg.mozilla.org/hgcustom/hghooks/file/default/mozhghooks/treeclosure.py will need updating.

Comment 2

[Chris Cooper [:coop] (he/him)]

Attachment: Adds birch to list of branches enforcing the tree closure hook

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 570327 [details] [diff] [review]
Adds birch to list of branches enforcing the tree closure hook

<ted impression> r+ </ted>

Comment 4

[Ben Kero [:bkero]]

Will somebody please apply this patch to the 'hghooks' repository and push their change, so we have a current copy of the hook in the repos, as well sa in production?

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 570327 [details] [diff] [review]
Adds birch to list of branches enforcing the tree closure hook

Checked in:

https://hg.mozilla.org/hgcustom/hghooks/rev/453947e9e9de

Comment 6

[Ben Kero [:bkero]]

I've added the updated hook, please let me know if you run into any issues.

Comment 7

[Matt Brubeck (:mbrubeck)]

This doesn't seem to be working; for example http://tinderbox.mozilla.org/Birch/status.html has <span id="treestatus" style="color: red;">CLOSED</span> right now, but it did not stop pushes from succeeding.

Comment 8

[Ben Kero [:bkero]]

I've found the issue was that the hooks were not correctly placed in the repository's hgrc file, only that the hook was updated to allow for the birch repository to be closed.

Please try again, I've enabled the hooks for the repository.