Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Initializing WebGL fake-black textures doesn't rebind previous texture bindings before drawing

RESOLVED FIXED in mozilla10

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
When there are textures in a context which (for an as-per-spec reason) must be rendered as black, we initialize face-black textures as a prefix to the next draw. When creating these textures, we naturally must change the current texture bindings, which is fine, as long as we reset them to their previous state when we're done. However, instead, we reset the 2d and cubemap textures to 0, instead of the previous values.

This causes the conformance tests for copyTexImage2D and copyTexSubImage2D to fail.
(Assignee)

Comment 1

6 years ago
Created attachment 570362 [details] [diff] [review]
Fix to rebind previous GL state after initializing fake-black textures

Short and sweet, but unbelievably annoying to track down. APITrace is awesome, though.
Attachment #570362 - Flags: review?(bjacob)
(Assignee)

Comment 2

6 years ago
Created attachment 570372 [details] [diff] [review]
Fix to rebind previous GL state after initializing fake-black textures

Removed copyTexImage2D and copySubTexImage2D from list of failing tests for all platforms.
Attachment #570362 - Attachment is obsolete: true
Attachment #570362 - Flags: review?(bjacob)
Attachment #570372 - Flags: review?(bjacob)
Attachment #570372 - Flags: review?(bjacob) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4f4dc3d3b20
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
(Assignee)

Comment 4

6 years ago
Removed [inbound] from whiteboard as per https://wiki.mozilla.org/Tree_Rules/Inbound
Whiteboard: [inbound]
Target Milestone: mozilla10 → ---
(Assignee)

Updated

6 years ago
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/c4f4dc3d3b20
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.