Closed Bug 698088 Opened 9 years ago Closed 9 years ago

Initializing WebGL fake-black textures doesn't rebind previous texture bindings before drawing

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file, 1 obsolete file)

When there are textures in a context which (for an as-per-spec reason) must be rendered as black, we initialize face-black textures as a prefix to the next draw. When creating these textures, we naturally must change the current texture bindings, which is fine, as long as we reset them to their previous state when we're done. However, instead, we reset the 2d and cubemap textures to 0, instead of the previous values.

This causes the conformance tests for copyTexImage2D and copyTexSubImage2D to fail.
Short and sweet, but unbelievably annoying to track down. APITrace is awesome, though.
Attachment #570362 - Flags: review?(bjacob)
Removed copyTexImage2D and copySubTexImage2D from list of failing tests for all platforms.
Attachment #570362 - Attachment is obsolete: true
Attachment #570362 - Flags: review?(bjacob)
Attachment #570372 - Flags: review?(bjacob)
Attachment #570372 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4f4dc3d3b20
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
Removed [inbound] from whiteboard as per https://wiki.mozilla.org/Tree_Rules/Inbound
Whiteboard: [inbound]
Target Milestone: mozilla10 → ---
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/c4f4dc3d3b20
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.